-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test #8723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise assertion failures there don't actually fail these tests.
LGTM |
Test build #42346 has finished for PR 8723 at commit
|
retest this please |
This actually already passed the |
asfgit
pushed a commit
that referenced
this pull request
Sep 11, 2015
…l the test This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly. Author: Andrew Or <[email protected]> Closes #8723 from andrewor14/fix-threading-suite. (cherry picked from commit d74c6a1) Signed-off-by: Andrew Or <[email protected]>
Test build #42355 has finished for PR 8723 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
…l the test (round 2) This is a follow-up patch to #8723. I missed one case there. Author: Andrew Or <[email protected]> Closes #8727 from andrewor14/fix-threading-suite.
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
…l the test (round 2) This is a follow-up patch to #8723. I missed one case there. Author: Andrew Or <[email protected]> Closes #8727 from andrewor14/fix-threading-suite. (cherry picked from commit 7b6c856) Signed-off-by: Andrew Or <[email protected]>
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
…l the test This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly. Author: Andrew Or <[email protected]> Closes apache#8723 from andrewor14/fix-threading-suite. (cherry picked from commit d74c6a1) Signed-off-by: Andrew Or <[email protected]> (cherry picked from commit fcb2438)
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
…l the test (round 2) This is a follow-up patch to apache#8723. I missed one case there. Author: Andrew Or <[email protected]> Closes apache#8727 from andrewor14/fix-threading-suite. (cherry picked from commit 7b6c856) Signed-off-by: Andrew Or <[email protected]> (cherry picked from commit 5db51f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly.