Skip to content

[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test #8723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly.

Otherwise assertion failures there don't actually fail these tests.
@srowen
Copy link
Member

srowen commented Sep 11, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Sep 11, 2015

Test build #42346 has finished for PR 8723 at commit a64e7c9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MultilayerPerceptronClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,
    • class MultilayerPerceptronClassificationModel(JavaModel):
    • class MinMaxScaler(JavaEstimator, HasInputCol, HasOutputCol):
    • class MinMaxScalerModel(JavaModel):
    • ("thresholds", "Thresholds in multi-class classification to adjust the probability of " +
    • class HasElasticNetParam(Params):
    • class HasFitIntercept(Params):
    • class HasStandardization(Params):
    • class HasThresholds(Params):
    • thresholds = Param(Params._dummy(), "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")
    • self.thresholds = Param(self, "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")

@andrewor14
Copy link
Contributor Author

retest this please

@andrewor14
Copy link
Contributor Author

This actually already passed the ThreadingSuite, so I'm merging it into master and 1.5. Thanks @srowen.

asfgit pushed a commit that referenced this pull request Sep 11, 2015
…l the test

This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly.

Author: Andrew Or <[email protected]>

Closes #8723 from andrewor14/fix-threading-suite.

(cherry picked from commit d74c6a1)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in d74c6a1 Sep 11, 2015
@SparkQA
Copy link

SparkQA commented Sep 11, 2015

Test build #42355 has finished for PR 8723 at commit a64e7c9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14 andrewor14 deleted the fix-threading-suite branch September 11, 2015 23:44
asfgit pushed a commit that referenced this pull request Sep 14, 2015
…l the test (round 2)

This is a follow-up patch to #8723. I missed one case there.

Author: Andrew Or <[email protected]>

Closes #8727 from andrewor14/fix-threading-suite.
asfgit pushed a commit that referenced this pull request Sep 14, 2015
…l the test (round 2)

This is a follow-up patch to #8723. I missed one case there.

Author: Andrew Or <[email protected]>

Closes #8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <[email protected]>
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
…l the test

This commit ensures if an assertion fails within a thread, it will ultimately fail the test. Otherwise we end up potentially masking real bugs by not propagating assertion failures properly.

Author: Andrew Or <[email protected]>

Closes apache#8723 from andrewor14/fix-threading-suite.

(cherry picked from commit d74c6a1)
Signed-off-by: Andrew Or <[email protected]>
(cherry picked from commit fcb2438)
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
…l the test (round 2)

This is a follow-up patch to apache#8723. I missed one case there.

Author: Andrew Or <[email protected]>

Closes apache#8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <[email protected]>
(cherry picked from commit 5db51f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants