-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-9996][SPARK-9997][SQL]Add local expand and NestedLoopJoin operators #8642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #42095 has finished for PR 8642 at commit
|
override def next(): Boolean = { | ||
idx += 1 | ||
if (idx < groups.length) { | ||
result = groups(idx)(input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, at this point input
hasn't been initialized yet has it? Did you intend to pass null
into the projection?
Test build #42330 has finished for PR 8642 at commit
|
Test build #42336 has finished for PR 8642 at commit
|
result = groups(idx)(input) | ||
idx += 1 | ||
true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about:
if (idx < 0 || idx >= groups.length) {
if (child.next()) {
input = child.fetch()
idx = 0
} else {
return false
}
}
result = groups(idx)(input)
idx += 1
true
a little less duplication
@zsxwing I left some suggestions on reducing code duplication, but otherwise this looks pretty good. |
@andrewor14 thanks for your reviewing. I updated this PR as per your comments. |
Test build #42421 has finished for PR 8642 at commit
|
LGTM, thanks I'm merging this into master. |
This PR is in conflict with #8535 and #8573. Will update this one when they are merged.