[SPARK-10430][Spark Core]Added hashCode methods in AccumulableInfo and RDDOperationScope #8581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkc
changed the title
|
ok to test |
| test("equals and hashCode") { | ||
| val opScope1 = new RDDOperationScope("scope1", id = "1") | ||
| val opScope2 = new RDDOperationScope("scope1", id = "1") | ||
| assert(opScope1 == opScope2) |
|
Looks good, thanks for fixing this. |
|
Test build #41961 has finished for PR 8581 at commit
|
|
Test build #41962 has finished for PR 8581 at commit
|
|
|
||
| override def hashCode(): Int = { | ||
| val state = Seq(id, name, update, value, internal) | ||
| state.map(_.hashCode).reduce(31 * _ + _) |
There was a problem hiding this comment.
Ah, something just occurred to me: you've been using reduce here but the operation isn't associative or commutative. I think it has to be reduceLeft to guarantee the output you want. Maybe update other instances of this in the code (from other PRs) here too?
|
Test build #41964 has finished for PR 8581 at commit
|
|
LGTM merging into master thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.