[SPARK-10411][SQL]Move visualization above explain output and hide explain by default #8570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andrewor14 |
zsxwing
changed the title
|
Test build #41927 has finished for PR 8570 at commit
|
|
For the details link - can you use the standard drop down icon we use in other places? |
|
@pwendell do you mean the triangle, e.g. |
|
Yes - I mean the triangle image used there and in a few other places (such as showing more metrics). |
|
Fixed it. These are the new screenshots.
|
|
Test build #41957 has finished for PR 8570 at commit
|
|
LGTM merging into master 1.5 thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 3, 2015
…explain by default New screenshots after this fix: <img width="627" alt="s1" src="https://cloud.githubusercontent.com/assets/1000778/9625782/4b2dba36-518b-11e5-9104-c713ff026e3d.png"> Default: <img width="462" alt="s2" src="https://cloud.githubusercontent.com/assets/1000778/9625817/92366e50-518b-11e5-9981-cdfb774d66b8.png"> After clicking `+details`: <img width="377" alt="s3" src="https://cloud.githubusercontent.com/assets/1000778/9625784/4ba24342-518b-11e5-8522-846a16a95d44.png"> Author: zsxwing <[email protected]> Closes #8570 from zsxwing/SPARK-10411. (cherry picked from commit 0349b5b) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New screenshots after this fix:
Default:
After clicking
+details: