-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[Spark-8530] [ML] add python API for MinMaxScaler #7150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #36235 has finished for PR 7150 at commit
|
reviewing now |
@@ -24,7 +24,7 @@ | |||
__all__ = ['Binarizer', 'HashingTF', 'IDF', 'IDFModel', 'NGram', 'Normalizer', 'OneHotEncoder', | |||
'PolynomialExpansion', 'RegexTokenizer', 'StandardScaler', 'StandardScalerModel', | |||
'StringIndexer', 'StringIndexerModel', 'Tokenizer', 'VectorAssembler', 'VectorIndexer', | |||
'Word2Vec', 'Word2VecModel'] | |||
'Word2Vec', 'Word2VecModel', 'MinMaxScaler', 'MinMaxScalerModel'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep sorted
This looks good, except for those tiny items & merge conflicts. |
Test build #41206 has finished for PR 7150 at commit
|
@jkbradley Sorry for the late update. I got some internet issues and cannot install Sphinx for now, so I simplified the comments. Let me know if it's not clear enough. |
@inherit_doc | ||
class MinMaxScaler(JavaEstimator, HasInputCol, HasOutputCol): | ||
""" | ||
Rescale each feature individually to a common range [min, max] linearly using column summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark with .. note:: Experimental
@hhbyyh Can you please fix the merge conflicts? I have time to get this merged now. Thanks! |
Test build #42237 has finished for PR 7150 at commit
|
@jkbradley Updated according to the comments. Thanks for helping review. |
LGTM. Merging with master. Thanks! |
jira: https://issues.apache.org/jira/browse/SPARK-8530
add python API for MinMaxScaler
jira for MinMaxScaler: https://issues.apache.org/jira/browse/SPARK-7514