[WIP] remove expensive api from InternalRow #6869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #35092 has finished for PR 6869 at commit
|
| } | ||
| abstract class InternalRow extends Serializable { | ||
| /** Number of elements in the Row. */ | ||
| def size: Int = length |
There was a problem hiding this comment.
do we need size? maybe just keep one of length or size.
There was a problem hiding this comment.
agree. It's internal and we don't need to follow scala convention to provide size.
|
@davies can you update the pr description to include what you actually removed? |
|
@cloud-fan it will be fixed by #6876 |
| * @throws ClassCastException when data type does not match. | ||
| * @throws NullPointerException when value is null. | ||
| */ | ||
| def getString(i: Int): String = getAs[UTF8String](i).toString |
There was a problem hiding this comment.
As it's internal row, should we just return UTF8String?
There was a problem hiding this comment.
Maybe we can only define getUTF8String at InternalRow and define getString at user-facing Row?
|
Close this, in favor of #7003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #6792, to use narrow down the APIs in InternalRow (remove those expensive ones).