[SPARK-6917] [SQL] DecimalType is not read back when non-native type exists #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regression test? |
|
Yeah, let's add a test. |
|
regression test added. |
|
Test build #33917 has finished for PR 6558 at commit
|
|
Test build #33927 has finished for PR 6558 at commit
|
| @@ -244,7 +244,7 @@ private[parquet] abstract class CatalystConverter extends GroupConverter { | |||
| * Read a decimal value from a Parquet Binary into "dest". Only supports decimals that fit in | |||
| * a long (i.e. precision <= 18) | |||
| */ | |||
| protected[parquet] def readDecimal(dest: Decimal, value: Binary, ctype: DecimalType): Unit = { | |||
| protected[parquet] def readDecimal(dest: Decimal, value: Binary, ctype: DecimalType): Decimal = { | |||
There was a problem hiding this comment.
oh, I just realized that when we reuse the Decimal value, we do not really need to use the returned value. But, we have another place that needs the returned value. Can we add a comment at here?
|
@yhuai fixed. |
|
Test build #33937 has finished for PR 6558 at commit
|
|
Test build #33938 has finished for PR 6558 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2015
…exists cc yhuai Author: Davies Liu <[email protected]> Closes #6558 from davies/decimalType and squashes the following commits: c877ca8 [Davies Liu] Update ParquetConverter.scala 48cc57c [Davies Liu] Update ParquetConverter.scala b43845c [Davies Liu] add test 3b4a94f [Davies Liu] DecimalType is not read back when non-native type exists (cherry picked from commit bcb47ad) Signed-off-by: Reynold Xin <[email protected]>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
…exists cc yhuai Author: Davies Liu <[email protected]> Closes apache#6558 from davies/decimalType and squashes the following commits: c877ca8 [Davies Liu] Update ParquetConverter.scala 48cc57c [Davies Liu] Update ParquetConverter.scala b43845c [Davies Liu] add test 3b4a94f [Davies Liu] DecimalType is not read back when non-native type exists
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…exists cc yhuai Author: Davies Liu <[email protected]> Closes apache#6558 from davies/decimalType and squashes the following commits: c877ca8 [Davies Liu] Update ParquetConverter.scala 48cc57c [Davies Liu] Update ParquetConverter.scala b43845c [Davies Liu] add test 3b4a94f [Davies Liu] DecimalType is not read back when non-native type exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @yhuai