Skip to content

[SPARK-7652][MLlib] Update the implementation of naive Bayes prediction with BLAS #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[SPARK-7652][MLlib] Update the implementation of naive Bayes prediction with BLAS #6189

wants to merge 5 commits into from

Conversation

viirya
Copy link
Member

@viirya viirya commented May 15, 2015

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32830 has finished for PR 6189 at commit 1b6cdfe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

mengxr
mengxr reviewed May 15, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala
@@ -27,7 +27,7 @@ import org.json4s.JsonDSL._
import org.json4s.jackson.JsonMethods._

import org.apache.spark.{Logging, SparkContext, SparkException}
import org.apache.spark.mllib.linalg.{BLAS, DenseVector, SparseVector, Vector}
import org.apache.spark.mllib.linalg.{BLAS, DenseMatrix, DenseVector, SparseVector, Vector, Vectors}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove the breeze imports now.

@SparkQA
Copy link

SparkQA commented May 16, 2015

Test build #32884 has finished for PR 6189 at commit 2f65186.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 16, 2015

@mengxr I added the support for SparseVector on gemv (only with DenseMatrix) in #6209. Also updated this PR to use it.

@SparkQA
Copy link

SparkQA commented May 16, 2015

Test build #32888 has finished for PR 6189 at commit b5772b4.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 16, 2015

@mengxr Looks like adding multiply(Vector) can't pass binary compatibility check. Any suggestion?

@viirya
Copy link
Member Author

viirya commented May 16, 2015

Can we add it into MimaExcludes?

@viirya viirya mentioned this pull request May 18, 2015
Closed
@viirya
Copy link
Member Author

viirya commented May 18, 2015

I added it into MimaExcludes in #6209 . If it is merged, this PR can use it.

viirya added 2 commits May 19, 2015 16:56
@viirya
Merge remote-tracking branch 'upstream/master' into naive_bayes_blas_…
ddc48b9 
…prediction

Conflicts:
	mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala
	mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala
@viirya
Remove unnecessary space.
ab611fd
@SparkQA
Copy link

SparkQA commented May 19, 2015

Test build #33069 has finished for PR 6189 at commit ab611fd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 19, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented May 19, 2015

Test build #33076 has finished for PR 6189 at commit ab611fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented May 19, 2015

LGTM. Merged into master and branch-1.4. Thanks!

@asfgit asfgit closed this in c12dff9 May 19, 2015
asfgit pushed a commit that referenced this pull request May 19, 2015
@viirya @mengxr
[SPARK-7652] [MLLIB] Update the implementation of naive Bayes predict…
5643499 
…ion with BLAS

JIRA: https://issues.apache.org/jira/browse/SPARK-7652

Author: Liang-Chi Hsieh <[email protected]>

Closes #6189 from viirya/naive_bayes_blas_prediction and squashes the following commits:

ab611fd [Liang-Chi Hsieh] Remove unnecessary space.
ddc48b9 [Liang-Chi Hsieh] Merge remote-tracking branch 'upstream/master' into naive_bayes_blas_prediction
b5772b4 [Liang-Chi Hsieh] Fix binary compatibility.
2f65186 [Liang-Chi Hsieh] Remove toDense.
1b6cdfe [Liang-Chi Hsieh] Update the implementation of naive Bayes prediction with BLAS.

(cherry picked from commit c12dff9)
Signed-off-by: Xiangrui Meng <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@viirya @jeanlyn
[SPARK-7652] [MLLIB] Update the implementation of naive Bayes predict…
d303c6b 
…ion with BLAS

JIRA: https://issues.apache.org/jira/browse/SPARK-7652

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#6189 from viirya/naive_bayes_blas_prediction and squashes the following commits:

ab611fd [Liang-Chi Hsieh] Remove unnecessary space.
ddc48b9 [Liang-Chi Hsieh] Merge remote-tracking branch 'upstream/master' into naive_bayes_blas_prediction
b5772b4 [Liang-Chi Hsieh] Fix binary compatibility.
2f65186 [Liang-Chi Hsieh] Remove toDense.
1b6cdfe [Liang-Chi Hsieh] Update the implementation of naive Bayes prediction with BLAS.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@viirya @jeanlyn
[SPARK-7652] [MLLIB] Update the implementation of naive Bayes predict…
657f755 
…ion with BLAS

JIRA: https://issues.apache.org/jira/browse/SPARK-7652

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#6189 from viirya/naive_bayes_blas_prediction and squashes the following commits:

ab611fd [Liang-Chi Hsieh] Remove unnecessary space.
ddc48b9 [Liang-Chi Hsieh] Merge remote-tracking branch 'upstream/master' into naive_bayes_blas_prediction
b5772b4 [Liang-Chi Hsieh] Fix binary compatibility.
2f65186 [Liang-Chi Hsieh] Remove toDense.
1b6cdfe [Liang-Chi Hsieh] Update the implementation of naive Bayes prediction with BLAS.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@viirya @nemccarthy
[SPARK-7652] [MLLIB] Update the implementation of naive Bayes predict…
fb4d117 
…ion with BLAS

JIRA: https://issues.apache.org/jira/browse/SPARK-7652

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#6189 from viirya/naive_bayes_blas_prediction and squashes the following commits:

ab611fd [Liang-Chi Hsieh] Remove unnecessary space.
ddc48b9 [Liang-Chi Hsieh] Merge remote-tracking branch 'upstream/master' into naive_bayes_blas_prediction
b5772b4 [Liang-Chi Hsieh] Fix binary compatibility.
2f65186 [Liang-Chi Hsieh] Remove toDense.
1b6cdfe [Liang-Chi Hsieh] Update the implementation of naive Bayes prediction with BLAS.
@viirya viirya deleted the naive_bayes_blas_prediction branch December 27, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viirya @SparkQA @mengxr