Skip to content

[SPARK-7466] DAG visualization: fix orphan nodes #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

Simple fix. We were comparing an option with null.

Before:

After:

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32214 has started for PR 6002 at commit a1468dc.

@andrewor14
Copy link
Contributor Author

@tdas @zsxwing FYI this is the issue

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32214 has finished for PR 6002 at commit a1468dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32214/
Test PASSed.

@zsxwing
Copy link
Member

zsxwing commented May 8, 2015

Verified the bug is fixed by this PR. Thank you. LGTM.

asfgit pushed a commit that referenced this pull request May 8, 2015
Simple fix. We were comparing an option with `null`.

Before:
<img src="https://issues.apache.org/jira/secure/attachment/12731383/before.png" width="250px"/>
After:
<img src="https://issues.apache.org/jira/secure/attachment/12731384/after.png" width="250px"/>

Author: Andrew Or <[email protected]>

Closes #6002 from andrewor14/dag-viz-orphan-nodes and squashes the following commits:

a1468dc [Andrew Or] Fix null check

(cherry picked from commit 3b0c5e7)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 3b0c5e7 May 8, 2015
@andrewor14 andrewor14 deleted the dag-viz-orphan-nodes branch May 8, 2015 21:13
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Simple fix. We were comparing an option with `null`.

Before:
<img src="https://issues.apache.org/jira/secure/attachment/12731383/before.png" width="250px"/>
After:
<img src="https://issues.apache.org/jira/secure/attachment/12731384/after.png" width="250px"/>

Author: Andrew Or <[email protected]>

Closes apache#6002 from andrewor14/dag-viz-orphan-nodes and squashes the following commits:

a1468dc [Andrew Or] Fix null check
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Simple fix. We were comparing an option with `null`.

Before:
<img src="https://issues.apache.org/jira/secure/attachment/12731383/before.png" width="250px"/>
After:
<img src="https://issues.apache.org/jira/secure/attachment/12731384/after.png" width="250px"/>

Author: Andrew Or <[email protected]>

Closes apache#6002 from andrewor14/dag-viz-orphan-nodes and squashes the following commits:

a1468dc [Andrew Or] Fix null check
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Simple fix. We were comparing an option with `null`.

Before:
<img src="https://issues.apache.org/jira/secure/attachment/12731383/before.png" width="250px"/>
After:
<img src="https://issues.apache.org/jira/secure/attachment/12731384/after.png" width="250px"/>

Author: Andrew Or <[email protected]>

Closes apache#6002 from andrewor14/dag-viz-orphan-nodes and squashes the following commits:

a1468dc [Andrew Or] Fix null check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants