Skip to content

[SPARK-7187] SerializationDebugger should not crash user code #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-7187] SerializationDebugger should not crash user code #5734

wants to merge 2 commits into from

Conversation

andrewor14
Copy link
Contributor

rxin
rxin reviewed Apr 28, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala
new NotSerializableException(
e.getMessage + "\nSerialization stack:\n" + find(obj).map("\t- " + _).mkString("\n"))
} catch {
case e2: Exception =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case NonFatal(e2)

@SparkQA
Copy link

SparkQA commented Apr 28, 2015

Test build #31120 has finished for PR 5734 at commit 57d0ef4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 28, 2015

Merging in master & branch-1.3.

asfgit pushed a commit that referenced this pull request Apr 28, 2015
@rxin
[SPARK-7187] SerializationDebugger should not crash user code
02ef8c3 
rxin

Author: Andrew Or <[email protected]>

Closes #5734 from andrewor14/ser-deb and squashes the following commits:

e8aad6c [Andrew Or] NonFatal
57d0ef4 [Andrew Or] try catch improveException

(cherry picked from commit bf35edd)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in bf35edd Apr 28, 2015
@SparkQA
Copy link

SparkQA commented Apr 28, 2015

Test build #31122 has finished for PR 5734 at commit e8aad6c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait LDAOptimizer
    • class EMLDAOptimizer extends LDAOptimizer
  • This patch does not change any dependencies.

@andrewor14 andrewor14 deleted the ser-deb branch April 28, 2015 15:33
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
[SPARK-7187] SerializationDebugger should not crash user code
f3b8f13 
rxin

Author: Andrew Or <[email protected]>

Closes apache#5734 from andrewor14/ser-deb and squashes the following commits:

e8aad6c [Andrew Or] NonFatal
57d0ef4 [Andrew Or] try catch improveException
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7187] SerializationDebugger should not crash user code
6607b65 
rxin

Author: Andrew Or <[email protected]>

Closes apache#5734 from andrewor14/ser-deb and squashes the following commits:

e8aad6c [Andrew Or] NonFatal
57d0ef4 [Andrew Or] try catch improveException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewor14 @SparkQA @rxin