-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-7039][SQL]JDBCRDD: Add support on type NVARCHAR #5618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@szheng79 Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark -- you need to update the title of this PR. |
@@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging { | |||
case java.sql.Types.NCLOB => StringType | |||
case java.sql.Types.NULL => null | |||
case java.sql.Types.NUMERIC => DecimalType.Unlimited | |||
case java.sql.Types.NVARCHAR => StringType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do u mind aligning the arrows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, I thought I made aligning, but I guess it caused by mixing space and tab, now I all use tab there.
Jenkins, test this please. |
Test build #30772 has finished for PR 5618 at commit
|
Thanks. I've merged this. |
Issue: https://issues.apache.org/jira/browse/SPARK-7039 Add support to column type NVARCHAR in Sql Server java.sql.Types: http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html Author: szheng79 <[email protected]> Closes #5618 from szheng79/patch-1 and squashes the following commits: 10da99c [szheng79] Update JDBCRDD.scala eab0bd8 [szheng79] Add support on type NVARCHAR (cherry picked from commit fbe7106) Signed-off-by: Reynold Xin <[email protected]>
Issue: https://issues.apache.org/jira/browse/SPARK-7039 Add support to column type NVARCHAR in Sql Server java.sql.Types: http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html Author: szheng79 <[email protected]> Closes apache#5618 from szheng79/patch-1 and squashes the following commits: 10da99c [szheng79] Update JDBCRDD.scala eab0bd8 [szheng79] Add support on type NVARCHAR (cherry picked from commit fbe7106) Signed-off-by: Reynold Xin <[email protected]>
Issue: https://issues.apache.org/jira/browse/SPARK-7039 Add support to column type NVARCHAR in Sql Server java.sql.Types: http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html Author: szheng79 <[email protected]> Closes apache#5618 from szheng79/patch-1 and squashes the following commits: 10da99c [szheng79] Update JDBCRDD.scala eab0bd8 [szheng79] Add support on type NVARCHAR
Issue: https://issues.apache.org/jira/browse/SPARK-7039 Add support to column type NVARCHAR in Sql Server java.sql.Types: http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html Author: szheng79 <[email protected]> Closes apache#5618 from szheng79/patch-1 and squashes the following commits: 10da99c [szheng79] Update JDBCRDD.scala eab0bd8 [szheng79] Add support on type NVARCHAR
How can I create a schema outside of spark containing columns with varchar and nvarchar and then save a dataframe with truncate = true and avoid an invalid datatype error for TEXT in Netezza by registering a new dialect? My current dialect has StringType mapped to either varchar or nvarchar but I can't have both and I'm failing to understand how to customize and persists table schemas without my dialects over-writing everything. Using spark 2.1. |
Issue:
https://issues.apache.org/jira/browse/SPARK-7039
Add support to column type NVARCHAR in Sql Server
java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html