Skip to content

[SPARK-7039][SQL]JDBCRDD: Add support on type NVARCHAR #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

szheng79
Copy link
Contributor

Issue:

https://issues.apache.org/jira/browse/SPARK-7039

Add support to column type NVARCHAR in Sql Server

java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html

@szheng79 szheng79 changed the title Add support on type NVARCHAR JDBCRDD: Add to support on type NVARCHAR Apr 21, 2015
@srowen
Copy link
Member

srowen commented Apr 21, 2015

@szheng79 Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark -- you need to update the title of this PR.

@@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging {
case java.sql.Types.NCLOB => StringType
case java.sql.Types.NULL => null
case java.sql.Types.NUMERIC => DecimalType.Unlimited
case java.sql.Types.NVARCHAR => StringType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u mind aligning the arrows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I thought I made aligning, but I guess it caused by mixing space and tab, now I all use tab there.

@szheng79 szheng79 changed the title JDBCRDD: Add to support on type NVARCHAR [SPARK-7039][SQL]JDBCRDD: Add support on type NVARCHAR Apr 22, 2015
@rxin
Copy link
Contributor

rxin commented Apr 22, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Apr 22, 2015

Test build #30772 has finished for PR 5618 at commit 10da99c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 22, 2015

Thanks. I've merged this.

asfgit pushed a commit that referenced this pull request Apr 22, 2015
Issue:

https://issues.apache.org/jira/browse/SPARK-7039

Add support to column type NVARCHAR in Sql Server

java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html

Author: szheng79 <[email protected]>

Closes #5618 from szheng79/patch-1 and squashes the following commits:

10da99c [szheng79] Update JDBCRDD.scala
eab0bd8 [szheng79] Add support on type NVARCHAR

(cherry picked from commit fbe7106)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in fbe7106 Apr 22, 2015
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Apr 23, 2015
Issue:

https://issues.apache.org/jira/browse/SPARK-7039

Add support to column type NVARCHAR in Sql Server

java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html

Author: szheng79 <[email protected]>

Closes apache#5618 from szheng79/patch-1 and squashes the following commits:

10da99c [szheng79] Update JDBCRDD.scala
eab0bd8 [szheng79] Add support on type NVARCHAR

(cherry picked from commit fbe7106)
Signed-off-by: Reynold Xin <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
Issue:

https://issues.apache.org/jira/browse/SPARK-7039

Add support to column type NVARCHAR in Sql Server

java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html

Author: szheng79 <[email protected]>

Closes apache#5618 from szheng79/patch-1 and squashes the following commits:

10da99c [szheng79] Update JDBCRDD.scala
eab0bd8 [szheng79] Add support on type NVARCHAR
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Issue:

https://issues.apache.org/jira/browse/SPARK-7039

Add support to column type NVARCHAR in Sql Server

java.sql.Types:
http://docs.oracle.com/javase/7/docs/api/java/sql/Types.html

Author: szheng79 <[email protected]>

Closes apache#5618 from szheng79/patch-1 and squashes the following commits:

10da99c [szheng79] Update JDBCRDD.scala
eab0bd8 [szheng79] Add support on type NVARCHAR
@robbyki
Copy link

robbyki commented Jan 4, 2018

How can I create a schema outside of spark containing columns with varchar and nvarchar and then save a dataframe with truncate = true and avoid an invalid datatype error for TEXT in Netezza by registering a new dialect? My current dialect has StringType mapped to either varchar or nvarchar but I can't have both and I'm failing to understand how to customize and persists table schemas without my dialects over-writing everything. Using spark 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants