Skip to content

Conversation

kayousterhout
Copy link
Contributor

The TaskContextHelper was originally necessary because TaskContext was written in Java, which does
not have a way to specify that classes are package-private, so TaskContextHelper existed to work
around this. Now that TaskContext has been re-written in Scala, this class is no longer necessary.

@rxin can you look at this? It looks like you missed this bit of cleanup when you moved TaskContext from Java to Scala in #4324

cc @ScrapCodes and @pwendell who added this originally.

The TaskContextHelper was originally necessary because TaskContext was written in Java, which does
not have a way to specify that classes are package-private, so TaskContextHelper existed to work
around this. Now that TaskContext has been re-written in Scala, this class is no longer necessary.
@rxin
Copy link
Contributor

rxin commented Apr 7, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Apr 7, 2015

Test build #29811 has finished for PR 5402 at commit f089800.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@pwendell
Copy link
Contributor

pwendell commented Apr 7, 2015

LGTM

On Tue, Apr 7, 2015 at 6:26 PM, UCB AMPLab [email protected] wrote:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29811/
Test PASSed.


Reply to this email directly or view it on GitHub
#5402 (comment).

@ScrapCodes
Copy link
Member

(Though it is redundant to say. :) ) LGTM too.

@rxin
Copy link
Contributor

rxin commented Apr 8, 2015

I'm merging this in master. Thanks.

@asfgit asfgit closed this in 8d2a36c Apr 8, 2015
@kayousterhout kayousterhout deleted the SPARK-6754 branch April 11, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants