[SPARK-53077][CORE][TESTS] Add an env to control the execution of the SparkBloomFilterSuite
#51806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +34,7 @@ | |||
| import java.util.stream.LongStream; | |||
| import java.util.stream.Stream; | |||
|
|
|||
| @Disabled("TODO(SPARK-53077): Re-enable with a resonable test time.") | |||
| @EnabledIfEnvironmentVariable(named = "SPARK_TEST_SPARK_BF_SUITE_ENABLED", matches = "true") | |||
There was a problem hiding this comment.
Since this can be a role model for this kind of environment variable group, can we have a rule?
For example, if we have a rule SPARK_TEST_${CLASSNAME}_ENABLED, this should be SPARK_TEST_SPARK_BLOOM_FILTER_SUITE_ENABLED.
Although BF is reasonable, it looks like not a rule-based name from the suite name.
.github/workflows/build_java21.yml
Outdated
| @@ -41,7 +41,8 @@ jobs: | |||
| "PYTHON_TO_TEST": "python3.11", | |||
| "SKIP_MIMA": "true", | |||
| "SKIP_UNIDOC": "true", | |||
| "DEDICATED_JVM_SBT_TESTS": "org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV1Suite,org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV2Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV1Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV2Suite" | |||
| "DEDICATED_JVM_SBT_TESTS": "org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV1Suite,org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV2Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV1Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV2Suite", | |||
| "SPARK_TEST_SPARK_BF_SUITE_ENABLED": "true" | |||
There was a problem hiding this comment.
Shall we remove this? Since this is a sketch module, I guess build_non_ansi.yml is enough because it's irrelevant to ANSI/non-ANSI.
|
Thank you for making an improvement, @LuciferYang . |
|
@dongjoon-hyun Thank you for your review. I'll make the revisions later. |
LuciferYang
changed the title
SparkBloomFilterSuite
peter-toth
approved these changes
Aug 4, 2025
LuciferYang
changed the title
SparkBloomFilterSuiteSparkBloomFilterSuite
LuciferYang
changed the title
SparkBloomFilterSuiteSparkBloomFilterSuite
|
Merged into master. Thanks @dongjoon-hyun and @peter-toth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr adds an environment variable named
SPARK_TEST_SPARK_BLOOM_FILTER_SUITE_ENABLEDto control whether the test caseSparkBloomFilterSuiteis executed. It also ensures that this test case is only run for validation in the daily tests specified inbuild_non_ansi.yml.Why are the changes needed?
The
SparkBloomFilterSuiterequires periodic validation, but due to its excessively long execution time (over 10 minutes), it is not suitable for execution in the Change Pipeline.Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual verification:
Was this patch authored or co-authored using generative AI tooling?
No