[WIP] Fix problem in NestedColumnAliasing.scala , replaceWithAliases in connection with Generate plan node #49061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one uses replaceWithChildren, one has to be careful with Generate plan nodes. Generate contains a list unrequiredChildIndex of unneeded child outputs in the Generate output. This data has to be adjusted accordingly. Otherwise an incorrect plan may be generated during optimisation. Here is an example (tested with Spark 3.5.3):
One can see, that the generated plan is invalid (extract_c#19 is missing in the in previous Project) and yields an error during execution. With this fix, the problem does not occur.