Skip to content

[Fix #274] Document + fix annotation usages #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

... so that we don't follow an unspoken set of forbidden rules for adding @AlphaComponent, @DeveloperAPI, and @experimental annotations in the code.

In addition, this PR
(1) removes unnecessary :: * :: tags,
(2) adds missing :: * :: tags, and
(3) removes annotations for internal APIs.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14309/

@pwendell
Copy link
Contributor

Thanks I'm merging this - there is an issue with the binary checker for sql... we'll need to fix it.

@asfgit asfgit closed this in b3e5366 Apr 22, 2014
asfgit pushed a commit that referenced this pull request Apr 22, 2014
... so that we don't follow an unspoken set of forbidden rules for adding **@AlphaComponent**, **@DeveloperAPI**, and **@experimental** annotations in the code.

In addition, this PR
(1) removes unnecessary `:: * ::` tags,
(2) adds missing `:: * ::` tags, and
(3) removes annotations for internal APIs.

Author: Andrew Or <[email protected]>

Closes #470 from andrewor14/annotations-fix and squashes the following commits:

92a7f42 [Andrew Or] Document + fix annotation usages
(cherry picked from commit b3e5366)

Signed-off-by: Patrick Wendell <[email protected]>
@andrewor14 andrewor14 deleted the annotations-fix branch April 23, 2014 00:49
pwendell added a commit to pwendell/spark that referenced this pull request May 12, 2014
Only log error on missing jar to allow spark examples to jar.

Right now to run the spark examples on Yarn you have to use the --addJars option and put the jar in hdfs.  To make that nicer  so the user doesn't have to specify the --addJars option change it to simply log an error instead of throwing.
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
... so that we don't follow an unspoken set of forbidden rules for adding **@AlphaComponent**, **@DeveloperAPI**, and **@experimental** annotations in the code.

In addition, this PR
(1) removes unnecessary `:: * ::` tags,
(2) adds missing `:: * ::` tags, and
(3) removes annotations for internal APIs.

Author: Andrew Or <[email protected]>

Closes apache#470 from andrewor14/annotations-fix and squashes the following commits:

92a7f42 [Andrew Or] Document + fix annotation usages
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
Only log error on missing jar to allow spark examples to jar.

Right now to run the spark examples on Yarn you have to use the --addJars option and put the jar in hdfs.  To make that nicer  so the user doesn't have to specify the --addJars option change it to simply log an error instead of throwing.
(cherry picked from commit 792d908)

Signed-off-by: Patrick Wendell <[email protected]>
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017
* Fix conversion from GB to MiB

Previously we applied a value which was in units MiB to Kubernetes _as if_ it
were in MB units.  Now, place MiB units in variable names and apply them to
Kubernetes as the correct MiB units.

* Fix test

* Update tests
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
This patch add a new nodeset for gpu resource type.

Related-Bug: theopenlab/openlab#197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants