Skip to content

[SPARK-46680][BUILD] Upgrade Apache commons-pool2 to 2.12.0 #44683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jan 11, 2024

What changes were proposed in this pull request?

This pr aims to upgrade Apache commons-pool2 from 2.11.1 to 2.12.0.

Why are the changes needed?

The new version bring some bug fix like:

  • POOL-401: Ensure that capacity freed by invalidateObject is available to all keyed pools.
  • POOL-391: Ensure capacity freed by clear is made available to GKOP borrowers.
  • POOL-402: Check blockWhenExhausted in hasBorrowWaiters
  • POOL-405: NullPointerException GenericKeyedObjectPool.invalidateObject(GenericKeyedObjectPool.java:1343)
  • POOL-393: Improve BaseGenericObjectPool's JMX Register performance when creating many pools.
  • POOL-411: Guard against NPE when deregistering a key at the end of borrow.

The full change we can refer to https://github.com/apache/commons-pool/blob/rel/commons-pool-2.12.0/RELEASE-NOTES.txt

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang marked this pull request as draft January 11, 2024 05:50
@github-actions github-actions bot added the BUILD label Jan 11, 2024
@LuciferYang LuciferYang changed the title Test commons-pool2 2.12.0 [WIP] Test commons-pool2 2.12.0 Jan 11, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if this is ready, @LuciferYang . 😄

@LuciferYang LuciferYang changed the title [WIP] Test commons-pool2 2.12.0 [SPARK-46680][BUILD] Upgrade Apache commons-pool2 to 2.12.0 Jan 11, 2024
@LuciferYang LuciferYang marked this pull request as ready for review January 11, 2024 11:54
@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun it's ready now ~

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @LuciferYang .
Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants