-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was causing UISeleniumSuite to fail with ClassNotFoundExceptions when run the hadoop-2.3 or hadoop-2.4 profiles. The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html
Note that we had previously rejected a patch that would have done this same version bumping, but I think that was because there wasn't a Spark-specific motivation for upgrading: #3654 (comment) |
@pwendell if you want to reproduce the old UISeleniumSuite Jenkins failures locally, you can run
after packaging Spark. I ran this locally to confirm that this patch fixes that issue. |
Test build #27017 has started for PR 4454 at commit
|
Note that the actual dependency conflict here involves an old version of I think we need version 4.2.3 or higher of I guess we could fix this by adding an explicit test-scoped dependency on the newer version of |
+1 to updating to 0.9.2 (0.9.3 even?) for all the reasons you've cited here. There wasn't a reason not to update before, just not obviously a reason to. Now there is. |
It looks like 0.9.3 has been released, but it's not on Maven Central yet: http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22net.java.dev.jets3t%22 |
Test build #27017 has finished for PR 4454 at commit
|
Test PASSed. |
I'm going to go ahead and merge this into |
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was causing UISeleniumSuite to fail with ClassNotFoundExceptions when run the hadoop-2.3 or hadoop-2.4 profiles. The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html Author: Josh Rosen <[email protected]> Closes #4454 from JoshRosen/SPARK-5671 and squashes the following commits: fa6cb3e [Josh Rosen] [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles (cherry picked from commit 5de14cc) Signed-off-by: Josh Rosen <[email protected]>
…adoop-2.4 profiles This is a follow-up PR for #4454 and #4484. JetS3t 0.9.2 contains a log4j.properties file inside the artifact and breaks our tests (see SPARK-5696). This is fixed in 0.9.3. This PR also reverts hotfix changes introduced in #4484. The reason is that asking users to configure HiveThriftServer2 logging configurations in hive-log4j.properties can be unintuitive. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4499) <!-- Reviewable:end --> Author: Cheng Lian <[email protected]> Closes #4499 from liancheng/spark-5700 and squashes the following commits: 4f020c7 [Cheng Lian] Bumps jets3t to 0.9.3 for hadoop-2.3 and hadoop-2.4 profiles
…adoop-2.4 profiles This is a follow-up PR for #4454 and #4484. JetS3t 0.9.2 contains a log4j.properties file inside the artifact and breaks our tests (see SPARK-5696). This is fixed in 0.9.3. This PR also reverts hotfix changes introduced in #4484. The reason is that asking users to configure HiveThriftServer2 logging configurations in hive-log4j.properties can be unintuitive. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4499) <!-- Reviewable:end --> Author: Cheng Lian <[email protected]> Closes #4499 from liancheng/spark-5700 and squashes the following commits: 4f020c7 [Cheng Lian] Bumps jets3t to 0.9.3 for hadoop-2.3 and hadoop-2.4 profiles (cherry picked from commit ba66793) Signed-off-by: Cheng Lian <[email protected]>
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.
The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html