Skip to content

[SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JoshRosen
Copy link
Contributor

Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.

The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html

Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.

The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html
@JoshRosen
Copy link
Contributor Author

/cc @pwendell @srowen.

Note that we had previously rejected a patch that would have done this same version bumping, but I think that was because there wasn't a Spark-specific motivation for upgrading: #3654 (comment)

@JoshRosen
Copy link
Contributor Author

@pwendell if you want to reproduce the old UISeleniumSuite Jenkins failures locally, you can run

build/mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0 test -DwildcardSuites=org.apache.spark.ui.UISeleniumSuite -Dtest=none

after packaging Spark.

I ran this locally to confirm that this patch fixes that issue.

@SparkQA
Copy link

SparkQA commented Feb 7, 2015

Test build #27017 has started for PR 4454 at commit fa6cb3e.

  • This patch merges cleanly.

@JoshRosen
Copy link
Contributor Author

Note that the actual dependency conflict here involves an old version of httpcomponets.httpclient being pulled in via the jets3t dependency. I ran into a variant of this problem when working on the original PR for the UISeleniumSuite (#2474) but didn't have to add a workaround for it there since some build changes in other PRs ended up fixing this issue.

I think we need version 4.2.3 or higher of httpcomponents.httpclient, but jets3t 0.9.0 depends on 4.1.2, which is why the older version was causing a problem here.

I guess we could fix this by adding an explicit test-scoped dependency on the newer version of httpcomponents, but I thought this approach seemed easier unless there's a strong motivation to not upgrade to 0.9.2.

@srowen
Copy link
Member

srowen commented Feb 7, 2015

+1 to updating to 0.9.2 (0.9.3 even?) for all the reasons you've cited here. There wasn't a reason not to update before, just not obviously a reason to. Now there is.

@JoshRosen
Copy link
Contributor Author

It looks like 0.9.3 has been released, but it's not on Maven Central yet: http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22net.java.dev.jets3t%22

@SparkQA
Copy link

SparkQA commented Feb 8, 2015

Test build #27017 has finished for PR 4454 at commit fa6cb3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27017/
Test PASSed.

@JoshRosen
Copy link
Contributor Author

I'm going to go ahead and merge this into master (1.4.0) and branch-1.3 (1.3.0) in order to un-break those Jenkins builds.

asfgit pushed a commit that referenced this pull request Feb 8, 2015
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.

The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html

Author: Josh Rosen <[email protected]>

Closes #4454 from JoshRosen/SPARK-5671 and squashes the following commits:

fa6cb3e [Josh Rosen] [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles

(cherry picked from commit 5de14cc)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 5de14cc Feb 8, 2015
asfgit pushed a commit that referenced this pull request Feb 10, 2015
…adoop-2.4 profiles

This is a follow-up PR for #4454 and #4484. JetS3t 0.9.2 contains a log4j.properties file inside the artifact and breaks our tests (see SPARK-5696). This is fixed in 0.9.3.

This PR also reverts hotfix changes introduced in #4484. The reason is that asking users to configure HiveThriftServer2 logging configurations in hive-log4j.properties can be unintuitive.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4499)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #4499 from liancheng/spark-5700 and squashes the following commits:

4f020c7 [Cheng Lian] Bumps jets3t to 0.9.3 for hadoop-2.3 and hadoop-2.4 profiles
asfgit pushed a commit that referenced this pull request Feb 10, 2015
…adoop-2.4 profiles

This is a follow-up PR for #4454 and #4484. JetS3t 0.9.2 contains a log4j.properties file inside the artifact and breaks our tests (see SPARK-5696). This is fixed in 0.9.3.

This PR also reverts hotfix changes introduced in #4484. The reason is that asking users to configure HiveThriftServer2 logging configurations in hive-log4j.properties can be unintuitive.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4499)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #4499 from liancheng/spark-5700 and squashes the following commits:

4f020c7 [Cheng Lian] Bumps jets3t to 0.9.3 for hadoop-2.3 and hadoop-2.4 profiles

(cherry picked from commit ba66793)
Signed-off-by: Cheng Lian <[email protected]>
@JoshRosen JoshRosen deleted the SPARK-5671 branch February 10, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants