Skip to content

[SPARK-5317]Set BoostingStrategy.defaultParams With Enumeration Algo.Classification or Algo.Regression #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

Peishen-Jia
Copy link
Contributor

JIRA Issue: https://issues.apache.org/jira/browse/SPARK-5317
When setting the BoostingStrategy.defaultParams("Classification"), It's more straightforward to set it with the Enumeration Algo.Classification, just like BoostingStragety.defaultParams(Algo.Classification).
I overload the method BoostingStragety.defaultParams().

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mengxr
Copy link
Contributor

mengxr commented Jan 19, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jan 19, 2015

Test build #25764 has started for PR 4103 at commit d5c8a2e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 19, 2015

Test build #25764 has finished for PR 4103 at commit d5c8a2e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25764/
Test PASSed.

@@ -506,7 +506,7 @@ JavaRDD<LabeledPoint> testData = splits[1];

// Train a GradientBoostedTrees model.
// The defaultParams for Classification use LogLoss by default.
BoostingStrategy boostingStrategy = BoostingStrategy.defaultParams("Classification");
BoostingStrategy boostingStrategy = BoostingStrategy.defaultParams(Algo.Classification);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in Java. You need at least "Algo.Classification()`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that I am a little careless about the docs of Java version. I will update it.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25865 has started for PR 4103 at commit 7c1e6ee.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25865 has finished for PR 4103 at commit 7c1e6ee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25865/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25933 has started for PR 4103 at commit 3b72875.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25933 has finished for PR 4103 at commit 3b72875.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25933/
Test PASSed.

@@ -70,20 +70,31 @@ object BoostingStrategy {

/**
* Returns default configuration for the boosting algorithm
* @param algoStr Learning goal. Supported:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad. In Scala, the parameter name is part of the API. So let's not rename algo to algoStr.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25943 has started for PR 4103 at commit 87bab1c.

  • This patch merges cleanly.

@mengxr
Copy link
Contributor

mengxr commented Jan 22, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25943 has finished for PR 4103 at commit 87bab1c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25943/
Test PASSed.

@asfgit asfgit closed this in fcb3e18 Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants