Skip to content

[Fix #204] Update out-dated comments #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Fix #204] Update out-dated comments #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,11 +1182,7 @@ class SparkContext(config: SparkConf) extends Logging {
listenerBus.post(SparkListenerApplicationStart(appName, startTime, sparkUser))
}

/**
* Post the application end event to all listeners immediately, rather than adding it
* to the event queue for it to be asynchronously processed eventually. Otherwise, a race
* condition exists in which the listeners may stop before this event has been propagated.
*/
/** Post the application end event */
private def postApplicationEnd() {
listenerBus.post(SparkListenerApplicationEnd(System.currentTimeMillis))
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ import org.apache.spark.util.JsonProtocol
/**
* A SparkListenerBus that replays logged events from persisted storage.
*
* This class expects files to be appropriately prefixed as specified in EventLoggingListener.
* There exists a one-to-one mapping between ReplayListenerBus and event logging applications.
* This assumes the given paths are valid log files, where each line can be deserialized into
* exactly one SparkListenerEvent.
*/
private[spark] class ReplayListenerBus(
logPaths: Seq[Path],
Expand Down