Skip to content

[SPARK-4632][Streaming] Upgrade MQTT dependency to latest version #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tdas
Copy link
Contributor

@tdas tdas commented Nov 27, 2014

MQTT client 0.4.0 was removed from the Eclipse Paho repository, and hence is breaking Spark build. This upgrades the version of MQTT client. This is an alternative approach to #3485 for unblocking Spark 1.2 release.

Note that whether the MQTT functionality is still working after this upgrade is not really being tested as the unit test does not actually transfer data. So only API compatibility is ensured. Adding a real unit test has been noted as another JIRA (https://issues.apache.org/jira/browse/SPARK-4631). For the purpose of unblocking Spark 1.2 release, I am ready to make this upgrade even with the slight risk of breaking MQTT functionality.

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23909 has started for PR 3487 at commit 9b1afe0.

  • This patch merges cleanly.

<artifactId>mqtt-client</artifactId>
<version>0.4.0</version>
<artifactId>org.eclipse.paho.client.mqttv3</artifactId>
<version>1.0.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: version should be indented at the same level as artifactId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrgggh .. my bad. should fix existing bug.

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23910 has started for PR 3487 at commit 4f5e53c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23909 has finished for PR 3487 at commit 9b1afe0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23909/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23910 has finished for PR 3487 at commit 4f5e53c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23910/
Test PASSed.

@JoshRosen
Copy link
Contributor

I think we can close this now, since #3495 was merged in (I like this PR's description better, though, so I wish this version had been merged :( ).

@pwendell
Copy link
Contributor

pwendell commented Dec 4, 2014

Yeah let's close this issue.

@asfgit asfgit closed this in 3cdae03 Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants