-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-4632][Streaming] Upgrade MQTT dependency to latest version #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #23909 has started for PR 3487 at commit
|
<artifactId>mqtt-client</artifactId> | ||
<version>0.4.0</version> | ||
<artifactId>org.eclipse.paho.client.mqttv3</artifactId> | ||
<version>1.0.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: version should be indented at the same level as artifactId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrgggh .. my bad. should fix existing bug.
Test build #23910 has started for PR 3487 at commit
|
Test build #23909 has finished for PR 3487 at commit
|
Test PASSed. |
Test build #23910 has finished for PR 3487 at commit
|
Test PASSed. |
I think we can close this now, since #3495 was merged in (I like this PR's description better, though, so I wish this version had been merged :( ). |
Yeah let's close this issue. |
MQTT client 0.4.0 was removed from the Eclipse Paho repository, and hence is breaking Spark build. This upgrades the version of MQTT client. This is an alternative approach to #3485 for unblocking Spark 1.2 release.
Note that whether the MQTT functionality is still working after this upgrade is not really being tested as the unit test does not actually transfer data. So only API compatibility is ensured. Adding a real unit test has been noted as another JIRA (https://issues.apache.org/jira/browse/SPARK-4631). For the purpose of unblocking Spark 1.2 release, I am ready to make this upgrade even with the slight risk of breaking MQTT functionality.