Skip to content

[SPARK-4604][MLLIB] make MatrixFactorizationModel public #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-4604][MLLIB] make MatrixFactorizationModel public #3459

wants to merge 3 commits into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 25, 2014

User could construct an MF model directly. I added a note about the performance.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23845 has started for PR 3459 at commit a624c12.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23845 has finished for PR 3459 at commit a624c12.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23845/
Test PASSed.

jkbradley
jkbradley reviewed Nov 25, 2014
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
@@ -28,13 +28,16 @@ import org.apache.spark.rdd.RDD
/**
* Model representing the result of matrix factorization.
*
* NB: If you create the model directly using constructor, please be aware that fast prediction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "NB" mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB = "Nota Bene", just "note well"

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23855 has started for PR 3459 at commit ed08214.

  • This patch merges cleanly.

jkbradley
jkbradley reviewed Nov 26, 2014
View reviewed changes
mllib/src/test/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModelSuite.scala

import org.apache.spark.mllib.util.MLlibTestSparkContext
import org.apache.spark.rdd.RDD
import org.scalatest.FunSuite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organize imports

@jkbradley
Copy link
Member

@mengxr Except for the imports, LGTM

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23860 has started for PR 3459 at commit f64bcd3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23855 has finished for PR 3459 at commit ed08214.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23855/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23860 has finished for PR 3459 at commit f64bcd3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23860/
Test PASSed.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 26, 2014

@jkbradley Thanks! I've merged this into master and branch-1.2.

mengxr added a commit to mengxr/spark that referenced this pull request Nov 26, 2014
@mengxr
[SPARK-4604][MLLIB] make MatrixFactorizationModel public
2756d0d 
User could construct an MF model directly. I added a note about the performance.

Author: Xiangrui Meng <[email protected]>

Closes apache#3459 from mengxr/SPARK-4604 and squashes the following commits:

f64bcd3 [Xiangrui Meng] organize imports
ed08214 [Xiangrui Meng] check preconditions and unit tests
a624c12 [Xiangrui Meng] make MatrixFactorizationModel public

(cherry picked from commit b5fb141)
Signed-off-by: Xiangrui Meng <[email protected]>
mengxr added a commit to mengxr/spark that referenced this pull request Nov 26, 2014
@mengxr
[SPARK-4604][MLLIB] make MatrixFactorizationModel public
b749000 
User could construct an MF model directly. I added a note about the performance.

Author: Xiangrui Meng <[email protected]>

Closes apache#3459 from mengxr/SPARK-4604 and squashes the following commits:

f64bcd3 [Xiangrui Meng] organize imports
ed08214 [Xiangrui Meng] check preconditions and unit tests
a624c12 [Xiangrui Meng] make MatrixFactorizationModel public

(cherry picked from commit b5fb141)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr mengxr mentioned this pull request Nov 26, 2014
Closed
@asfgit asfgit closed this in b5fb141 Nov 26, 2014
asfgit pushed a commit that referenced this pull request Nov 26, 2014
@mengxr
[BRANCH-1.2][SPARK-4604][MLLIB] make MatrixFactorizationModel public
9b63900 
We reverted #3459 in branch-1.2 due to missing `import o.a.s.SparkContext._`, which is no longer needed in master (#3262). This PR adds #3459 back to branch-1.2 with correct imports.

Github is out-of-sync now. The real changes are the last two commits.

Author: Xiangrui Meng <[email protected]>

Closes #3473 from mengxr/SPARK-4604-1.2 and squashes the following commits:

a7638a5 [Xiangrui Meng] add import o.a.s.SparkContext._ for v1.2
b749000 [Xiangrui Meng] [SPARK-4604][MLLIB] make MatrixFactorizationModel public
@zsxwing zsxwing mentioned this pull request Dec 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengxr @SparkQA @AmplabJenkins @jkbradley @srowen