Skip to content

[SPARK-4599] [Build] [SQL] add hive profile in root pom #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-4599] [Build] [SQL] add hive profile in root pom #3450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@
</dependencies>
</profile>
<profile>
<id>hive-thriftserver</id>
<id>hive</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? there are already profiles covering activation of Hive itself below; this profile is supposed to be about thriftserver and is so named.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have hive-thriftserver always included when we have -Phive

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases we want to build one but not the other. For instance Scala 2.11 does not yet support the thirftserver due to a dependency conflict.

<modules>
<module>sql/hive-thriftserver</module>
</modules>
Expand Down