SPARK-4507: PR merge script should support closing multiple JIRA tickets #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This patch isn't very clear for reviewing, you moved a lot of codes. 👍 |
|
I'll try not to move codes more than necessary |
| def resolve_jira_issues(title, merge_branches, comment): | ||
| jira_ids = re.findall("SPARK-[0-9]{4,5}", title) | ||
|
|
||
| for jira_id in jira_ids: |
There was a problem hiding this comment.
does this change the behavior when there are no JIRAs of the correct form in the title, such that we now won't prompt the user?
|
Jenkins, test this please. |
|
Test build #23951 has started for PR 3428 at commit
|
|
LGTM pending tests. |
|
Test build #23951 has finished for PR 3428 at commit
|
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix SPARK-4507.
For pull requests that reference multiple JIRAs in their titles, it would be helpful if the PR merge script offered to close all of them.