Skip to content

[SPARK-4075][SPARK-4434] Fix the URI validation logic for Application Jar name. #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[SPARK-4075][SPARK-4434] Fix the URI validation logic for Application Jar name. #3326

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d4f47e
Added a test case as a regression check for SPARK-4434
sarutak Nov 17, 2014
ac79906
Merge branch 'master' of git://git.apache.org/spark into add-triple-s…
sarutak Nov 18, 2014
d4b99ef
[SPARK-4075] [Deploy] Jar url validation is not enough for Jar file
sarutak Oct 24, 2014
9e09da2
Fixed URI validation for jar file
sarutak Nov 18, 2014
4f30210
Modified comments
sarutak Nov 18, 2014
c1c80ca
Fixed style
sarutak Nov 18, 2014
9149027
Merge branch 'master' of git://git.apache.org/spark into add-triple-s…
sarutak Nov 18, 2014
82bc9cc
Fixed wrong grammar in comment
sarutak Nov 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/test/scala/org/apache/spark/deploy/ClientSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class ClientSuite extends FunSuite with Matchers {
test("correctly validates driver jar URL's") {
ClientArguments.isValidJarUrl("http://someHost:8080/foo.jar") should be (true)
ClientArguments.isValidJarUrl("file://some/path/to/a/jarFile.jar") should be (true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your change, but this should not be a valid jar URL right? My understanding is that one or three slashes are valid, but not two.

ClientArguments.isValidJarUrl("file:///some/path/to/a/jarFile.jar") should be (true)
ClientArguments.isValidJarUrl("hdfs://someHost:1234/foo.jar") should be (true)

ClientArguments.isValidJarUrl("hdfs://someHost:1234/foo") should be (false)
Expand Down