Skip to content

[SQL] support udt to hive types conversion (hive->udt is not supported) #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SQL] support udt to hive types conversion (hive->udt is not supported) #3164

wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 8, 2014

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23089 has started for PR 3164 at commit 57c7519.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23089 has finished for PR 3164 at commit 57c7519.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23089/
Test PASSed.

scwf
scwf reviewed Nov 8, 2014
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
@@ -390,6 +390,7 @@ object HiveMetastoreTypes extends RegexParsers {
case d: DecimalType => HiveShim.decimalMetastoreString(d)
case TimestampType => "timestamp"
case NullType => "void"
case udt: UserDefinedType[_] => toMetastoreType(udt.sqlType)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, should this place first? just as in ScalaReflection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering doesn't matter here. I put it to the last so people know that it won't change any existing behavior.

@marmbrus
Copy link
Contributor

Thanks! Merged to master and 1.2.

asfgit pushed a commit that referenced this pull request Nov 10, 2014
@mengxr @marmbrus
[SQL] support udt to hive types conversion (hive->udt is not supported)
9b781c8 
marmbrus

Author: Xiangrui Meng <[email protected]>

Closes #3164 from mengxr/hive-udt and squashes the following commits:

57c7519 [Xiangrui Meng] support udt->hive types (hive->udt is not supported)

(cherry picked from commit 894a724)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 894a724 Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengxr @SparkQA @AmplabJenkins @marmbrus @scwf