-
Notifications
You must be signed in to change notification settings - Fork 28.7k
SPARK-1297 Upgrade HBase dependency to 0.98 #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
<groupId>org.eclipse.jetty</groupId> | ||
<artifactId>jetty-server</artifactId> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: these lines are not aligned with the other dependencies.
What effect will this have on people who want/need to compile against other versions of hbase? I know hbase has been a little fast and loose about changing the structure of their dependencies, so maybe the answer is "tough luck", and that's probably fine. |
hbase 0.98 has been declared stable release. Since hbase 0.94 is not modularized, compilation against 0.94 or earlier releases wouldn't be supported. |
Can one of the admins verify this patch? |
@vanzin this only affects the Spark examples project, which is isolated from our normal build. So I think for normal spark users it's a no-op one way or the other. |
Jenkins, test this please. |
Test build #23083 has started for PR 3115 at commit
|
Test build #23083 has finished for PR 3115 at commit
|
Test PASSed. |
pwendell rxin Please take a look Author: tedyu <[email protected]> Closes #3115 from tedyu/master and squashes the following commits: 2b079c8 [tedyu] SPARK-1297 Upgrade HBase dependency to 0.98 (cherry picked from commit b32734e) Signed-off-by: Patrick Wendell <[email protected]>
The |
@cloud-fan I think it depends on whether the code uses |
Thanks Sean for chiming in. bq. Most people wouldn't depend on the server |
@pwendell @rxin
Please take a look