Skip to content

[SPARK-33850][SQL][FOLLOWUP] Improve and cleanup the test code #30861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-33850][SQL][FOLLOWUP] Improve and cleanup the test code #30861

wants to merge 2 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Dec 20, 2020

What changes were proposed in this pull request?

This PR mainly improves and cleans up the test code introduced in #30855 based on the comment.
The test code is actually taken from another test explain formatted - check presence of subquery in case of DPP so this PR cleans the code too ( removed unnecessary withTable).

Why are the changes needed?

To keep the test code clean.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

ExplainSuite passes.

@github-actions github-actions bot added the SQL label Dec 20, 2020
@sarutak sarutak force-pushed the followup-SPARK-33850 branch from 5f68689 to e3ae481 Compare December 20, 2020 07:07
@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37699/

@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37699/

maropu
maropu reviewed Dec 20, 2020
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala Outdated
.mode("overwrite")
.saveAsTable("df1")
withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
withTable("df") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withTempView?

@maropu
Copy link
Member

maropu commented Dec 20, 2020

Looks fine otherwise.

@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Test build #133099 has finished for PR 30861 at commit e3ae481.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37711/

@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37711/

@SparkQA
Copy link

SparkQA commented Dec 20, 2020

Test build #133112 has finished for PR 30861 at commit 658cc92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133112/

@maropu
Copy link
Member

maropu commented Dec 21, 2020

Thanks! Merged to master. cc: @dongjoon-hyun

@maropu maropu closed this Dec 21, 2020
maropu pushed a commit that referenced this pull request Dec 21, 2020
@sarutak @maropu
[SPARK-33850][SQL][FOLLOWUP] Improve and cleanup the test code
3c8be39 
### What changes were proposed in this pull request?

This PR mainly improves and cleans up the test code introduced in #30855 based on the comment.
The test code is actually taken from another test `explain formatted - check presence of subquery in case of DPP` so this PR cleans the code too ( removed unnecessary `withTable`).

### Why are the changes needed?

To keep the test code clean.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`ExplainSuite` passes.

Closes #30861 from sarutak/followup-SPARK-33850.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
@dongjoon-hyun
Copy link
Member

Thank you, @sarutak and @maropu .

dongjoon-hyun pushed a commit that referenced this pull request Dec 21, 2020
@sarutak @dongjoon-hyun
[SPARK-33850][SQL][FOLLOWUP] Improve and cleanup the test code
a1eea37 
### What changes were proposed in this pull request?

This PR mainly improves and cleans up the test code introduced in #30855 based on the comment.
The test code is actually taken from another test `explain formatted - check presence of subquery in case of DPP` so this PR cleans the code too ( removed unnecessary `withTable`).

### Why are the changes needed?

To keep the test code clean.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`ExplainSuite` passes.

Closes #30861 from sarutak/followup-SPARK-33850.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit 3c8be39)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

Since the original PR is on branch-3.1, I backport this to branch-3.1, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maropu maropu maropu approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarutak @SparkQA @maropu @AmplabJenkins @dongjoon-hyun