Revert "[SPARK-32481][CORE][SQL] Support truncate table to move data to trash" #30463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to trash" This reverts commit 065f173.
|
Got it, @gatorsmile . |
|
I am okay with this revert. |
|
Sure got it |
|
Thanks for pinging @gatorsmile . Agree with your reasoning and +1 on this. |
|
Kubernetes integration test starting |
|
Looks okay. |
|
Kubernetes integration test status success |
|
Test build #131533 has finished for PR 30463 at commit
|
HyukjinKwon
approved these changes
Nov 23, 2020
viirya
approved these changes
Nov 23, 2020
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 065f173, which is not part of any released version. That is, this is an unreleased feature
Why are the changes needed?
I like the concept of Trash, but I think this PR might just resolve a very specific issue by introducing a mechanism without a proper design doc. This could make the usage more complex.
I think we need to consider the big picture. Trash directory is an important concept. If we decide to introduce it, we should consider all the code paths of Spark SQL that could delete the data, instead of Truncate only. We also need to consider what is the current behavior if the underlying file system does not provide the API
Trash.moveToAppropriateTrash. Is the exception good? How about the performance when users are using the object store instead of HDFS? Will it impact the GDPR compliance?In sum, I think we should not merge the PR #29552 without the design doc and implementation plan. That is why I reverted it before the code freeze of Spark 3.1
Does this PR introduce any user-facing change?
Reverted the original commit
How was this patch tested?
The existing tests.