Skip to content

[SPARK-4149][SQL] ISO 8601 support for json date time strings #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adrian-wang
Copy link
Contributor

This implement the feature @davies mentioned in #2901 (diff)

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22518 has started for PR 3012 at commit c62b7e2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22518 has finished for PR 3012 at commit c62b7e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22518/
Test PASSed.

@davies
Copy link
Contributor

davies commented Oct 31, 2014

Thanks for working on it. Can it infer the type as DateType/TimestampType from String in Json? It's common to have date/time in json, such as create time of tweet, it will be great if we access it as TimestampType.

@adrian-wang
Copy link
Contributor Author

@davies I'd like to add auto detection in a separate PR.

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

Test build #23131 has started for PR 3012 at commit 50df6e7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

Test build #23131 has finished for PR 3012 at commit 50df6e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23131/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master and 1.2

@asfgit asfgit closed this in a1fc059 Nov 11, 2014
asfgit pushed a commit that referenced this pull request Nov 11, 2014
This implement the feature davies mentioned in #2901 (diff)

Author: Daoyuan Wang <[email protected]>

Closes #3012 from adrian-wang/iso8601 and squashes the following commits:

50df6e7 [Daoyuan Wang] json data timestamp ISO8601 support

(cherry picked from commit a1fc059)
Signed-off-by: Michael Armbrust <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants