-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-29290][CORE] Update to chill 0.9.5 #27227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #116813 has finished for PR 27227 at commit
|
Test build #116811 has finished for PR 27227 at commit
|
Retest this please. |
Test build #116879 has finished for PR 27227 at commit
|
The patch itself looks good to me, @srowen . The library is published yesterday and it seems that
|
Jenkins, retest this please |
Test build #116978 has finished for PR 27227 at commit
|
@dongjoon-hyun yeah I noticed this locally when using the Google mirror. Hm, I'm not sure how frequently they sync; this could become an issue. This isn't urgent so I'll sit on it a while, but after a week or so maybe we have to merge and then disable the mirror |
@srowen . If we disable the mirror, Maven Central will cause a flaky failure in GitHub Action. I'm also searching a nice way to avoid this sync issue. For now, there was no luck to me. |
BTW, Maven Central also looks weird to me. Technically, we can access https://repo1.maven.org/maven2/com/twitter/chill_2.12/0.9.5/ correctly, but the listing doesn't show it. However, the maven-metadata.xml is correct. |
For the latter, try refreshing. I do see it and can see https://repo1.maven.org/maven2/com/twitter/chill_2.12/0.9.5/ |
No. What I mean is |
You can not see 0.9.5 in the upper directory. (I've been using |
Oh, that's weird. I'm using both |
The following is
|
Weird, I curl'ed it too and do see 0.9.5. We may indeed be hitting different instances of the central repo. That is itself a bit troublesome if not all of even central has the artifact |
Hi, @srowen . I found a solution for this. Could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
Thank you for waiting, @srowen .
What changes were proposed in this pull request?
Update Twitter Chill to 0.9.5.
Why are the changes needed?
Primarily, Scala 2.13 support for later.
Other changes from 0.9.3 are apparently just minor fixes and improvements:
https://github.com/twitter/chill/releases
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests