[SPARK-30200][SQL] Add ExplainMode for Dataset.explain #26829
Closed
+156
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses-you
reviewed
Dec 10, 2019
| */ | ||
| def explain(extended: Boolean): Unit = { | ||
| def explain(mode: ExplainMode): Unit = { |
There was a problem hiding this comment.
How about retain the old api and add a new api ?
There was a problem hiding this comment.
@ulysses-you . @maropu already did. Please see line 564.
There was a problem hiding this comment.
Yea, we should keep this. Thanks for the comment, @dongjoon-hyun
|
Test build #115091 has finished for PR 26829 at commit
|
| @@ -132,13 +131,15 @@ case class DataWritingCommandExec(cmd: DataWritingCommand, child: SparkPlan) | |||
| * (but do NOT actually execute it). | |||
| * | |||
| * {{{ | |||
| * EXPLAIN (EXTENDED | CODEGEN) SELECT * FROM ... | |||
| * EXPLAIN (EXTENDED | CODEGEN | COST | FORMATTED) SELECT * FROM ... | |||
There was a problem hiding this comment.
Thank you for fixing this together.
dongjoon-hyun
approved these changes
Dec 10, 2019
|
Thanks for the check, @dongjoon-hyun ! |
ulysses-you
reviewed
Dec 11, 2019
| */ | ||
| Extended, | ||
| /** | ||
| * Extended mode means that when printing explain for a DataFrame, if generated codes are |
There was a problem hiding this comment.
oh... I'll do follow-up, thanks!
ulysses-you
reviewed
Dec 11, 2019
| */ | ||
| Codegen, | ||
| /** | ||
| * Extended mode means that when printing explain for a DataFrame, if plan node statistics are |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 11, 2019
### What changes were proposed in this pull request? This pr is a follow-up of #26829 to fix typos in ExplainMode. ### Why are the changes needed? For better docs. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? N/A Closes #26851 from maropu/SPARK-30200-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Dec 13, 2019
### What changes were proposed in this pull request? This pr intends to support explain modes implemented in #26829 for PySpark. ### Why are the changes needed? For better debugging info. in PySpark dataframes. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Added UTs. Closes #26861 from maropu/ExplainModeInPython. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr intends to add
ExplainModefor explainingDataset/DataFramewith a given format mode (ExplainMode).ExplainModehas four types along with the SQL EXPLAIN command:Simple,Extended,Codegen,Cost, andFormatted.For example, this pr enables users to explain DataFrame/Dataset with the
FORMATTEDformat implemented in #24759;This comes from the @cloud-fan suggestion.
Why are the changes needed?
To follow the SQL EXPLAIN command.
Does this PR introduce any user-facing change?
No, this is just for a new API in Dataset.
How was this patch tested?
Add tests in
ExplainSuite.