-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest #25788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I found the test below in
That's because |
858d940
to
b95aaa2
Compare
Thank you for adding this. This looks useful. |
Test build #110583 has finished for PR 25788 at commit
|
Test build #110582 has finished for PR 25788 at commit
|
b95aaa2
to
9f32999
Compare
Oh, is this ready, @maropu ? |
I'm checking if all the tests passed. I persnally think we need more time for #25827 but that pr does not block this pr. |
Test build #111101 has finished for PR 25788 at commit
|
retest this please |
Test build #111104 has finished for PR 25788 at commit
|
ok, could you check this? @dongjoon-hyun @viirya |
Of course, @maropu ~ I'll do today. |
@@ -82,13 +82,17 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with TPCDSSchema { | |||
"q3", "q7", "q10", "q19", "q27", "q34", "q42", "q43", "q46", "q52", "q53", "q55", "q59", | |||
"q63", "q65", "q68", "q73", "q79", "q89", "q98", "ss_max") | |||
|
|||
// List up the known queries having too large code in a generated function | |||
val blackListForMethodCodeSizeCheck = Set("modified-q3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an IDed TODO to remove this, @maropu ? SPARK-29128 is the one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we had better wait for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Test build #111132 has finished for PR 25788 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @maropu .
Although there is a blacklist query, this PR helps us a lot.
Merged to master.
Thanks, @dongjoon-hyun ! |
What changes were proposed in this pull request?
This pr proposes to check method bytecode size in
BenchmarkQueryTest
. This metric is critical for performance numbers.Why are the changes needed?
For performance checks
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A