SPARK-3404 [BUILD] SparkSubmitSuite fails with "spark-submit exits with code 1" #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid SparkSubmitSuite failure due to port conflict
|
QA tests have started for PR 2328 at commit
|
|
QA tests have finished for PR 2328 at commit
|
|
I guess this still doesn't fix the SBT test flakiness, but it should help with the Maven ones (at least bring them up to par with SBT). |
|
If this gives us a green build under Maven, it should also fix SPARK-2232. Getting the Maven master builds up to par with SBT would be a good milestone. It looks like the test failure here is due to a known issue that will be fixed in #2334. |
|
Merging in master. Thanks. |
| @@ -888,7 +888,7 @@ | |||
| <plugin> | |||
| <groupId>org.scalatest</groupId> | |||
| <artifactId>scalatest-maven-plugin</artifactId> | |||
| <version>1.0-RC2</version> | |||
| <version>1.0</version> | |||
There was a problem hiding this comment.
@srowen does this need to be back ported into 1.1 as well?
There was a problem hiding this comment.
Nah, this is not necessary to back-port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
SparkSubmitSuitefailure by setting<spark.ui.port>0</spark.ui.port>in the Maven build, to match the SBT build. This avoids a port conflict which causes failures.(This also updates the
scalatestplugin off of a release candidate, to the identical final release.)