-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-3379] Implement 'POWER' for sql #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
ok to test |
QA tests have started for PR 2252 at commit
|
For reference, how does this implementation of
|
Good comparison @nchammas, It odes not look like this implementation currently preserves the input type or supports decimal. |
QA tests have finished for PR 2252 at commit
|
} | ||
} | ||
|
||
val base_v = base.eval(input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Let's check if base_v
is null first and then compute exponent_v
, probably performance gains in some cases.
Thanks for working on this, but we are trying to clean up the PR queue (in order to make it easier for us to review). Thus, I think we should close this issue for now and reopen when its ready for review. |
Add support for the mathematical function "POWER" within spark sql. Test-cases included.
Spitted from [SPARK-3176].