Skip to content

[MINOR] Fix build failure due to non-direct conflict: removing import affects others #22178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Aug 21, 2018

What changes were proposed in this pull request?

Fix the build failure on master branch: #21733 removed import which #21469 referred to. They were not making direct conflict so cannot find the issue until running build after merging twos.

How was this patch tested?

Ran maven clean install -DskipTests. For tests I'd like to defer to CI build cause it will take hours.

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Aug 21, 2018

cc. @tdas

Turned out the patch which removed import was also mine.

@HeartSaVioR
Copy link
Contributor Author

a998e9d resolved this. @tdas was faster :) Closing.

@HeartSaVioR HeartSaVioR deleted the fix-build-failure-on-master branch August 22, 2018 00:11
@SparkQA
Copy link

SparkQA commented Aug 22, 2018

Test build #95062 has finished for PR 22178 at commit 533a536.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants