Skip to content

[MINOR] Add .crc files to .gitignore #22170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Aug 21, 2018

What changes were proposed in this pull request?

Add .crc files to .gitignore so that we don't add .crc files in state checkpoint to git repo which could be added in test resources.
This is based on comments in #21733, #21733 (comment).

How was this patch tested?

Add .1.delta.crc and .2.delta.crc in <spark root>/sql/core/src/test/resources, and confirm git doesn't suggest the files to add to stage.

@HeartSaVioR
Copy link
Contributor Author

cc. @tdas

@SparkQA
Copy link

SparkQA commented Aug 21, 2018

Test build #95013 has finished for PR 22170 at commit da31ee6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in d800632 Aug 21, 2018
@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Aug 21, 2018

@HyukjinKwon Thanks for reviewing and merging!

@HeartSaVioR HeartSaVioR deleted the add-crc-files-to-gitignore branch August 21, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants