[SPARK-22816][TEST] Basic tests for PromoteStrings and InConversion #20001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyum
changed the title
|
Test build #85007 has finished for PR 20001 at commit
|
|
Test build #85008 has finished for PR 20001 at commit
|
gatorsmile
reviewed
Dec 17, 2017
| SELECT cast(1 as string) in (cast('2017-12-11 09:30:00.0' as timestamp)) FROM t; | ||
| SELECT cast(1 as string) in (cast('2017-12-11 09:30:00' as date)) FROM t; | ||
| -- Hive and Spark SQL doesn't support below operations: | ||
| -- SELECT cast(1 as string) in (cast('1' as binary)) FROM t; |
There was a problem hiding this comment.
For the cases we do not support, we should still keep them.
Just ensure the type coercion rule is not changed and the error messages are reasonable.
|
Test build #85020 has finished for PR 20001 at commit
|
|
LGTM |
|
Thanks! Merged to master. |
|
Test build #85024 has finished for PR 20001 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test Coverage for
PromoteStringsandInConversion, this is a Sub-tasks for SPARK-22722.How was this patch tested?
N/A