-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-21790][TESTS][FOLLOW-UP] Add filter pushdown verification back. #19002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -39,7 +39,6 @@ import org.apache.spark.sql.catalyst.plans.PlanTest | |||
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan | |||
import org.apache.spark.sql.catalyst.util._ | |||
import org.apache.spark.sql.execution.FilterExec | |||
import org.apache.spark.sql.internal.SQLConf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I guess it's unrelated change. It wouldn't block this PR but I guess it's good to revert this one back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, i'll revert it.
Test build #80880 has finished for PR 19002 at commit
|
assert(parentPlan.isInstanceOf[WholeStageCodegenExec]) | ||
val node = parentPlan.asInstanceOf[WholeStageCodegenExec] | ||
val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata | ||
// The "PushedFilters" part should be exist in Datafrome's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Datafrome's
-> Dataframe's
LGTM except a minor comment. |
Test build #80886 has finished for PR 19002 at commit
|
retest this please |
Test build #80890 has finished for PR 19002 at commit
|
assert(parentPlan.isInstanceOf[WholeStageCodegenExec]) | ||
val node = parentPlan.asInstanceOf[WholeStageCodegenExec] | ||
val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata | ||
// The "PushedFilters" part should be exist in Dataframe's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little nit: should be exist
-> should exist
// physical plan and the existence of right literals in | ||
// "PushedFilters" is used to prove that the predicates | ||
// pushing down have been effective. | ||
assert(metadata.get("PushedFilters").ne(None)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could we use isDefined
instead of ne(None)
?
Test build #80919 has finished for PR 19002 at commit
|
retest this please |
Test build #80921 has finished for PR 19002 at commit
|
Thanks! Merging to master. |
What changes were proposed in this pull request?
The previous PR(#19000) removed filter pushdown verification, This PR add them back.
How was this patch tested?
manual tests