Skip to content

[SPARK-21790][TESTS][FOLLOW-UP] Add filter pushdown verification back. #19002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-21790][TESTS][FOLLOW-UP] Add filter pushdown verification back. #19002

wants to merge 4 commits into from

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Aug 20, 2017

What changes were proposed in this pull request?

The previous PR(#19000) removed filter pushdown verification, This PR add them back.

How was this patch tested?

manual tests

@@ -39,7 +39,6 @@ import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.catalyst.util._
import org.apache.spark.sql.execution.FilterExec
import org.apache.spark.sql.internal.SQLConf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I guess it's unrelated change. It wouldn't block this PR but I guess it's good to revert this one back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, i'll revert it.

@SparkQA
Copy link

SparkQA commented Aug 20, 2017

Test build #80880 has finished for PR 19002 at commit 71182dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

assert(parentPlan.isInstanceOf[WholeStageCodegenExec])
val node = parentPlan.asInstanceOf[WholeStageCodegenExec]
val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata
// The "PushedFilters" part should be exist in Datafrome's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datafrome's -> Dataframe's

@gatorsmile
Copy link
Member

LGTM except a minor comment.

@SparkQA
Copy link

SparkQA commented Aug 20, 2017

Test build #80886 has finished for PR 19002 at commit da88a85.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented Aug 20, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Aug 20, 2017

Test build #80890 has finished for PR 19002 at commit da88a85.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

assert(parentPlan.isInstanceOf[WholeStageCodegenExec])
val node = parentPlan.asInstanceOf[WholeStageCodegenExec]
val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata
// The "PushedFilters" part should be exist in Dataframe's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little nit: should be exist -> should exist

// physical plan and the existence of right literals in
// "PushedFilters" is used to prove that the predicates
// pushing down have been effective.
assert(metadata.get("PushedFilters").ne(None))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could we use isDefined instead of ne(None)?

@SparkQA
Copy link

SparkQA commented Aug 21, 2017

Test build #80919 has finished for PR 19002 at commit b24aedf.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented Aug 21, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Aug 21, 2017

Test build #80921 has finished for PR 19002 at commit b24aedf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in ba84329 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants