[SPARK-12399] Display correct error message when accessing REST API with an unknown app Id #10352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val ui = appCache.get(appKey) | ||
| Some(ui) | ||
| } catch { | ||
| case e: Exception => e.getCause() match { |
|
Test build #47915 has finished for PR 10352 at commit
|
|
retest this please |
|
Test build #47971 has finished for PR 10352 at commit
|
|
retest this please |
|
Test build #47990 has finished for PR 10352 at commit
|
| @@ -115,7 +117,17 @@ class HistoryServer( | |||
| } | |||
|
|
|||
| def getSparkUI(appKey: String): Option[SparkUI] = { | |||
| Option(appCache.get(appKey)) | |||
There was a problem hiding this comment.
is it a better fix to do appCache.getIfPresent here?
There was a problem hiding this comment.
appCache.getIfPresent returns null if there is no cached value for the appKey. But appCache.get will try to obtain that value from a CacheLoader, cache it and return it. So I think we still need use appCache.get here and handle the exception.
|
LGTM, merging to master and 1.6. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Dec 30, 2015
…ith an unknown app Id I got an exception when accessing the below REST API with an unknown application Id. `http://<server-url>:18080/api/v1/applications/xxx/jobs` Instead of an exception, I expect an error message "no such app: xxx" which is a similar error message when I access `/api/v1/applications/xxx` ``` org.spark-project.guava.util.concurrent.UncheckedExecutionException: java.util.NoSuchElementException: no app with key xxx at org.spark-project.guava.cache.LocalCache$Segment.get(LocalCache.java:2263) at org.spark-project.guava.cache.LocalCache.get(LocalCache.java:4000) at org.spark-project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at org.spark-project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874) at org.apache.spark.deploy.history.HistoryServer.getSparkUI(HistoryServer.scala:116) at org.apache.spark.status.api.v1.UIRoot$class.withSparkUI(ApiRootResource.scala:226) at org.apache.spark.deploy.history.HistoryServer.withSparkUI(HistoryServer.scala:46) at org.apache.spark.status.api.v1.ApiRootResource.getJobs(ApiRootResource.scala:66) ``` Author: Carson Wang <[email protected]> Closes #10352 from carsonwang/unknownAppFix. (cherry picked from commit b244297) Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an exception when accessing the below REST API with an unknown application Id.
http://<server-url>:18080/api/v1/applications/xxx/jobsInstead of an exception, I expect an error message "no such app: xxx" which is a similar error message when I access
/api/v1/applications/xxx