[SPARK-12244][SPARK-12245][STREAMING] Rename trackStateByKey to mapWithState and change tracking function signature #10224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47426 has finished for PR 10224 at commit
|
tdas
changed the title
tdas
changed the title
|
Could you search |
|
yeah. I am doing that. I havent updated the tests yet. |
| @@ -867,8 +865,8 @@ public void testTrackStateByAPI() { | |||
| JavaPairRDD<String, Boolean> initialRDD = null; | |||
There was a problem hiding this comment.
nit: the method name testTrackStateByAPI should be renamed to testMapWithStateAPI
tdas
changed the title
| * } | ||
| * | ||
| * val spec = StateSpec.function(trackingFunction).numPartitions(10) | ||
| * val spec = StateSpec.function(mappingFunction).numPartitions(10) |
|
Test build #47449 has finished for PR 10224 at commit
|
|
Test build #47447 has finished for PR 10224 at commit
|
| * JavaTrackStateDStream<Integer, Integer, Integer, String> trackStateDStream = | ||
| * keyValueDStream.<Integer, String>trackStateByKey( | ||
| * StateSpec.function(trackStateFunc).numPartitions(10)); | ||
| * JavaMapWithStateDStream<Integer, Integer, Integer, String> mapWithStateDStream = |
There was a problem hiding this comment.
nit: the key type is String now.
|
LGTM except some nits |
|
Test build #2191 has finished for PR 10224 at commit
|
|
Test build #47460 has finished for PR 10224 at commit
|
|
Test build #47467 has finished for PR 10224 at commit
|
|
LGTM |
|
merging to master and 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2015
…thState and change tracking function signature SPARK-12244: Based on feedback from early users and personal experience attempting to explain it, the name trackStateByKey had two problem. "trackState" is a completely new term which really does not give any intuition on what the operation is the resultant data stream of objects returned by the function is called in docs as the "emitted" data for the lack of a better. "mapWithState" makes sense because the API is like a mapping function like (Key, Value) => T with State as an additional parameter. The resultant data stream is "mapped data". So both problems are solved. SPARK-12245: From initial experiences, not having the key in the function makes it hard to return mapped stuff, as the whole information of the records is not there. Basically the user is restricted to doing something like mapValue() instead of map(). So adding the key as a parameter. Author: Tathagata Das <[email protected]> Closes #10224 from tdas/rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-12244:
Based on feedback from early users and personal experience attempting to explain it, the name trackStateByKey had two problem.
"trackState" is a completely new term which really does not give any intuition on what the operation is
the resultant data stream of objects returned by the function is called in docs as the "emitted" data for the lack of a better.
"mapWithState" makes sense because the API is like a mapping function like (Key, Value) => T with State as an additional parameter. The resultant data stream is "mapped data". So both problems are solved.
SPARK-12245:
From initial experiences, not having the key in the function makes it hard to return mapped stuff, as the whole information of the records is not there. Basically the user is restricted to doing something like mapValue() instead of map(). So adding the key as a parameter.