[SPARK-12136] [STREAMING] rddToFileName does not properly handle prefix and suffix parameters #10185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomeng
changed the title
bomeng
changed the title
| } | ||
| result.toString() |
There was a problem hiding this comment.
I think it's fine; it might be simpler without bothering with StringBuilder but not by much.
(In your code you should use val result and you do not need to assign result each time.)
var result = time.milliseconds.toString
if (prefix != null && prefix.length > 0) {
result = prefix + "-" result
}
if (suffix != null && suffix.length > 0) {
result = result + "." + suffix
}
result
There was a problem hiding this comment.
The code was changed according to your comments by using String instead.
|
Test build #2179 has finished for PR 10185 at commit
|
| prefix + "-" + time.milliseconds + "." + suffix | ||
| var result = time.milliseconds.toString | ||
| if (prefix != null && prefix.length > 0) { | ||
| result = prefix + "-" + result |
There was a problem hiding this comment.
lets use string interpolation for this.
|
LGTM |
|
Test build #2189 has finished for PR 10185 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2015
…x and suffix parameters The original code does not properly handle the cases where the prefix is null, but suffix is not null - the suffix should be used but is not. The fix is using StringBuilder to construct the proper file name. Author: bomeng <[email protected]> Author: Bo Meng <[email protected]> Closes #10185 from bomeng/SPARK-12136. (cherry picked from commit e29704f) Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code does not properly handle the cases where the prefix is null, but suffix is not null - the suffix should be used but is not.
The fix is using StringBuilder to construct the proper file name.