[SPARK-11824] [WEBUI] WebUI does not render descriptions with 'bad' HTML, throws console error #10159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… like "SELECT ... where foo <= 1"
|
Test build #47228 has finished for PR 10159 at commit
|
|
Just removing the warning seems pretty harmless, and I am fairly confident it's the right thing to do given the JIRA. I'm going to merge later today. |
|
So, I'm a little confused; is the text rendered correctly or not? If it is, then that part was not a bug, right (and doesn't need to be mentioned in the pr title)? |
|
@vanzin yeah the title seems wrong. The description is rendered unescaped in this case and is fine. The problem is the big warning-level stack trace in the console every time this happens. |
asfgit
pushed a commit
that referenced
this pull request
Dec 9, 2015
…ML, throws console error Don't warn when description isn't valid HTML since it may properly be like "SELECT ... where foo <= 1" The tests for this code indicate that it's normal to handle strings like this that don't contain HTML as a string rather than markup. Hence logging every such instance as a warning is too noisy since it's not a problem. this is an issue for stages whose name contain SQL like the above CC tdas as author of this bit of code Author: Sean Owen <[email protected]> Closes #10159 from srowen/SPARK-11824. (cherry picked from commit 1eb7c22) Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/1.6 to quiet the noise on the console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't warn when description isn't valid HTML since it may properly be like "SELECT ... where foo <= 1"
The tests for this code indicate that it's normal to handle strings like this that don't contain HTML as a string rather than markup. Hence logging every such instance as a warning is too noisy since it's not a problem. this is an issue for stages whose name contain SQL like the above
CC @tdas as author of this bit of code