-
Notifications
You must be signed in to change notification settings - Fork 105
Optimize loguru reporter plugin #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems the error is:
I test in my own repo as metioned in apache/skywalking#10723 after simpling the loguru test https://github.com/Jedore/skywalking-python/blob/ttt/tests/plugin/data/sw_loguru/services/provider.py. So i think may be the key is skywalking-agent-test-tool syntax |
It's my error. I have commited new fix. |
Thanks for fixing it, great work! |
The oap container in kafka e2e cases fails and it's not your problem. I'm investigating now. |
I see the problem, Kraft mode became default in our pulled bitnami kafka image and the configuration isn't enough for it. I will start another PR later today to fix that. |
LGTM and once the other PR is merged this one can merge. |
Should be in 1.0.1 or pending? |
This PR also fixes a potential reporter bug introduced in 1.0.0, so it will be included in the 1.0.1 patch. But no further features will be added beyond this pr. |
CI is still failing. |
GHA runners are not working properly, let's wait a bit and see if it passes. https://www.githubstatus.com/ |
Great, merging. |
Optimize the loguru reporter plugin.
CHANGELOG.md
.