Skip to content

Optimize loguru reporter plugin #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Optimize loguru reporter plugin #302

merged 6 commits into from
Apr 25, 2023

Conversation

Jedore
Copy link
Contributor

@Jedore Jedore commented Apr 23, 2023

Optimize the loguru reporter plugin.

@wu-sheng wu-sheng requested a review from Superskyyy April 23, 2023 09:10
@wu-sheng wu-sheng added this to the 1.1.0 milestone Apr 23, 2023
@Jedore
Copy link
Contributor Author

Jedore commented Apr 24, 2023

Seems the error is:

-         text: '2023-04-24 02:08:51.207 | WARNING  | __main__:application:44 - Loguru -           provider warning reported. 
+         text: Loguru provider warning reported.

and
https://github.com/apache/skywalking-python/actions/runs/4781572067/jobs/8500362225?pr=302#step:6:764

I test in my own repo as metioned in apache/skywalking#10723 after simpling the loguru test https://github.com/Jedore/skywalking-python/blob/ttt/tests/plugin/data/sw_loguru/services/provider.py.

So i think may be the key is skywalking-agent-test-tool syntax end with ?

@Jedore
Copy link
Contributor Author

Jedore commented Apr 24, 2023

It's my error. I have commited new fix.

@Superskyyy
Copy link
Member

Thanks for fixing it, great work!

@Superskyyy
Copy link
Member

The oap container in kafka e2e cases fails and it's not your problem. I'm investigating now.

@Superskyyy
Copy link
Member

I see the problem, Kraft mode became default in our pulled bitnami kafka image and the configuration isn't enough for it. I will start another PR later today to fix that.

@Superskyyy Superskyyy added enhancement New feature or request bug Something isn't working labels Apr 24, 2023
@Superskyyy
Copy link
Member

LGTM and once the other PR is merged this one can merge.

@wu-sheng
Copy link
Member

Should be in 1.0.1 or pending?

@Superskyyy
Copy link
Member

Should be in 1.0.1 or pending?

This PR also fixes a potential reporter bug introduced in 1.0.0, so it will be included in the 1.0.1 patch. But no further features will be added beyond this pr.

@wu-sheng
Copy link
Member

CI is still failing.

@Superskyyy
Copy link
Member

CI is still failing.

GHA runners are not working properly, let's wait a bit and see if it passes. https://www.githubstatus.com/

@Superskyyy
Copy link
Member

Great, merging.

@Superskyyy Superskyyy merged commit 25a04ad into apache:master Apr 25, 2023
@Jedore Jedore deleted the loguru branch June 10, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants