Skip to content

Add tables to show agent features and clean up configs #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

Superskyyy
Copy link
Member

@Superskyyy Superskyyy commented Jan 20, 2023

As Python agent grows and syncing features with the Java agent, even myself don't remember what was supported especially we have 3 reporter protocols (grpc http kafka) that not all of them support all telemetry data.

So adding two tables to show it clearly for our users/developers so they can quick start and avoid installing the wrong version.

Preview:
image

  • If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes:
  • Update the CHANGELOG.md.

@Superskyyy Superskyyy requested review from wu-sheng and kezhenxu94 and removed request for wu-sheng January 20, 2023 05:27
@wu-sheng
Copy link
Member

I can't find meter and log docs, but the table shows supported.
Are those missed docs?

@Superskyyy
Copy link
Member Author

I can't find meter and log docs, but the table shows supported. Are those missed docs?

The log reporter doc is here, but meter is missing. It's because we didn't add it to the menu.yaml, adding now.
image

@Superskyyy
Copy link
Member Author

@wu-sheng Btw, I remember HTTP handler (receiver) on meter is not implemented on the OAP side, is it intentional or just a missed thing not done?

@wu-sheng
Copy link
Member

It is just never defined from API level, and not implemented.
Feel free to add the API and implement it.

@Superskyyy Superskyyy added documentation Improvements or additions to documentation enhancement New feature or request feature New feature labels Jan 20, 2023
@Superskyyy Superskyyy added this to the 1.0.0 milestone Jan 20, 2023
@Superskyyy Superskyyy merged commit 59bf030 into apache:master Jan 20, 2023
@Superskyyy Superskyyy deleted the enhance_docs branch January 20, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants