-
Notifications
You must be signed in to change notification settings - Fork 105
Improved ignore path regex #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update test case, |
I think that a Just want to point out the potential mismatch with a common perception of glob syntax. What do you think? |
Could be mismatch with standard glob but the idea is to allow EDIT: Previous behavior was a little weird with no single wildcard pattern possible, for example
Now,
EDIT2: Or should |
I think you are right, this is indeed more robust. Probably adding a small FAQ documentation will be nice, so it eliminates user confusion. |
Other than this concern all LGTM. |
I was looking for a place to document this and found the following in "SW_TRACE_IGNORE_PATH: You can setup multiple URL path patterns, The endpoints match these patterns wouldn't be traced. the current matching rules follow Then, looking up
And:
And:
Which implies the previous behavior and test below did not actually follow the specification. Since now it does, there is nothing extra to document I think?
|
I see, I didn't take a careful look ealier. Then everything LGTM :) |
This is the same as skywalking-nodejs PR #81:
Minor enhancement/fix? Previously the config.trace_ignore_path pattern
/a/**/*
would match/a/b/
,/a/b/c
and/a/b/c/
, etc... but not/a/
or/a/b
. Now it does.