Skip to content

Remove places that mentions Python 3.5 support due to EOL #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

Superskyyy
Copy link
Member

Will test Python 3.10 when officially releases next month.

Signed-off-by: Superskyyy [email protected]

@kezhenxu94 kezhenxu94 added the chore Project chores label Sep 19, 2021
@kezhenxu94 kezhenxu94 added this to the 1.0.0 milestone Sep 19, 2021
@kezhenxu94
Copy link
Member

We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.

@Superskyyy
Copy link
Member Author

We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.

Ok, I intend to swap existing string formatting(% .format + etc.) to f-strings since they are much faster, but that does blocks all Python 3.5 users from v1.0.0, should I do that?

@kezhenxu94
Copy link
Member

We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.

Ok, I intend to swap existing string formatting(% .format + etc.) to f-strings since they are much faster, but that does blocks all Python 3.5 users from v1.0.0, should I do that?

That's awesome. We can do that, and just say since 1.0 we don't support 3.5.

@wu-sheng
Copy link
Member

As you said we will drop 3.5 supports, https://twitter.com/ASFSkyWalking/status/1439553219210792963.

@@ -19,7 +19,7 @@ microservices, cloud native and container-based (Docker, Kubernetes, Mesos) arch

## Installation Requirements

SkyWalking Python Agent requires SkyWalking 8.0+ and Python 3.5+.
SkyWalking Python Agent requires SkyWalking 8.0+ and Python 3.6+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, since the requirement here is version-ed, users should check the corresponding doc of their versions, this PR is good to me now

@kezhenxu94 kezhenxu94 merged commit cd8dde6 into apache:master Sep 19, 2021
@Superskyyy Superskyyy deleted the remove-py35 branch September 19, 2021 19:44
@kezhenxu94
Copy link
Member

Will test Python 3.10 when officially releases next month.

Seems 3.10 is out. @Superskyyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants