Adds setPrincipalSuffix() to AbstractLdapRealm & updates ActiveDirectoryRealm

[tbrugz]

Fixes #2308

By creating a new branch and resetting the old one (main), I've unintentionally closed the old PR (#2309)

Thanks for the suggestions, @lprimak !

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[fpapon]

@tbrugz thank you for your contribution! Is it possible for you to add a test for this issue?

[lprimak]

@fpapon It looks like the modified code is already covered by existing test.
Net new code is just a setter. I am not sure it's worth holding this up for a setter-type test.
What do you think?

[bmarwell]

I haven't touched this code in a while. It looks as if an oversight was fixed (suffix for the login username ONLY if it was not given by the user), but I cannot say much more about this.

I am not sure how this could or could not break things. I might have done something similar in my apps, but this seems safe enough. I'd say give it a try.

[tbrugz]

@fpapon, I've added a new test to check ActiveDirectoryRealm's property settings here: tbrugz@396c532

I've based the test on https://shiro.apache.org/testing.html (class ExampleShiroIntegrationTest). It uses the deprecated IniSecurityManagerFactory class, I hope that's ok.

Should I merge with this (PR) branch?

[fpapon]

@tbrugz thank you!