Update existing trigger feeds on create instead of failing #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubee
commented
Nov 18, 2019
action/lib/Database.js
Outdated
| reject(err); | ||
| if(err.statusCode && err.statusCode === 409) { | ||
| this.getTrigger(params.triggerName) | ||
| .then(() => this.disableTrigger(params.triggerName)) |
Member
Author
There was a problem hiding this comment.
I don't understand why all this async stuff is going on when the entire action functionality is blocking anyway...
Member
Author
|
@jasonpet, will definitely need your Node.js expertise on this one. |
dubee
force-pushed
the
trigger-create-update
branch
from
d8a183b to
c87016d
Compare
dubee
changed the title
dubee
force-pushed
the
trigger-create-update
branch
from
4aff3cc to
4634bc1
Compare
This was referenced Nov 20, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason a trigger is deleted, but the corresponding feed is not, allow a trigger in the same namespace with the same trigger name to be recreated with the existing feed.