Skip to content

fix(azure): API Version should be specified by clients#334

Merged
Xuanwo merged 2 commits into
mainfrom
add-version-support-for-azblob
May 31, 2023
Merged

fix(azure): API Version should be specified by clients#334
Xuanwo merged 2 commits into
mainfrom
add-version-support-for-azblob

Conversation

@Xuanwo

@Xuanwo Xuanwo commented May 31, 2023

Copy link
Copy Markdown
Member

No description provided.

Xuanwo added 2 commits May 31, 2023 11:35
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit aa28ce2 into main May 31, 2023
@Xuanwo Xuanwo deleted the add-version-support-for-azblob branch May 31, 2023 03:50
@sunng87

sunng87 commented May 31, 2023

Copy link
Copy Markdown

hey @Xuanwo , this breaks opendal azure backend:

443 |         let batch_signer = AzureStorageSigner::new().omit_service_version();
    |                                                      ^^^^^^^^^^^^^^^^^^^^ method not found in `AzureStorageSigner`

You might want to release this in a minor version bump

@Xuanwo

Xuanwo commented May 31, 2023

Copy link
Copy Markdown
Member Author

Oh, you are right.

@Xuanwo

Xuanwo commented May 31, 2023

Copy link
Copy Markdown
Member Author

I will yank this version first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants