-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ISSUE-10329] Document behaviour of UrlNormalizer #11568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[ISSUE-10329] Document behaviour of UrlNormalizer #11568
Conversation
|
@gnodet Highly unlikely the IT failed due to adding a comment and a unit test. Perhaps flaky or other issue? |
|
Just the usual |
|
Build uses Mimir and everything is cached except for Mimir itself (chicken or egg), but if Central spits HTTP 500 for Mimir, not much to do. |
|
Check. Thanks for rerunning, good to know it's a known issue |
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java
Outdated
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java
Outdated
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java
Outdated
Show resolved
Hide resolved
| */ | ||
| package org.apache.maven.api.services.model; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that we have an interface here. We don't really need it for anything, but that's tangential to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I agree that having an interface with 1 implementation is not as pure as it can be, though this is indeed a topic that is beyond the scope of this PR.
I think the same discussion lives in #10328
If there is a consensus on what path we are taking, we can act accordingly for this (and perhaps more) classes.
Closes #10329
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.