Skip to content

Conversation

@Giovds
Copy link
Contributor

@Giovds Giovds commented Dec 16, 2025

Closes #10329

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Giovds
Copy link
Contributor Author

Giovds commented Dec 16, 2025

@gnodet Highly unlikely the IT failed due to adding a comment and a unit test. Perhaps flaky or other issue?

@cstamas
Copy link
Member

cstamas commented Dec 16, 2025

Just the usual Could not transfer artifact eu.maveniverse.maven.mimir.node:file:pom:0.10.6 from/to central (https://repo.maven.apache.org/maven2): HTTP Status: 500

@cstamas
Copy link
Member

cstamas commented Dec 16, 2025

Build uses Mimir and everything is cached except for Mimir itself (chicken or egg), but if Central spits HTTP 500 for Mimir, not much to do.

@Giovds
Copy link
Contributor Author

Giovds commented Dec 17, 2025

Check. Thanks for rerunning, good to know it's a known issue

@Giovds Giovds requested a review from elharo December 17, 2025 15:37
*/
package org.apache.maven.api.services.model;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that we have an interface here. We don't really need it for anything, but that's tangential to this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I agree that having an interface with 1 implementation is not as pure as it can be, though this is indeed a topic that is beyond the scope of this PR.

I think the same discussion lives in #10328

If there is a consensus on what path we are taking, we can act accordingly for this (and perhaps more) classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNG-8747] UrlNormalizer insufficiently specified

4 participants